Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/SidebarPane.js

Issue 2153153003: DevTools: remove dead code, disambiguate expand for sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lcean Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/SidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/SidebarPane.js b/third_party/WebKit/Source/devtools/front_end/ui/SidebarPane.js
index b5b7764c6f6a3c295c0374523ed187b47a4acfb6..399fb9d9be59317b3f45e8dfc433fa98fcc2994b 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/SidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/SidebarPane.js
@@ -56,15 +56,7 @@ WebInspector.SidebarPane.prototype = {
return this._toolbar;
},
- /**
- * @return {string}
- */
- title: function()
- {
- return this._title;
- },
-
- expand: function()
+ expandPane: function()
{
this.onContentReady();
},
@@ -116,7 +108,7 @@ WebInspector.SidebarPaneTitle = function(container, pane)
this._pane = pane;
this.element = container.createChild("div", "sidebar-pane-title");
- this.element.textContent = pane.title();
+ this.element.textContent = pane._title;
this.element.tabIndex = 0;
this.element.addEventListener("click", this._toggleExpanded.bind(this), false);
this.element.addEventListener("keydown", this._onTitleKeyDown.bind(this), false);
@@ -141,7 +133,7 @@ WebInspector.SidebarPaneTitle.prototype = {
if (this.element.classList.contains("expanded"))
this._collapse();
else
- this._pane.expand();
+ this._pane.expandPane();
},
/**
@@ -213,7 +205,7 @@ WebInspector.SidebarTabbedPane.prototype = {
*/
addPane: function(pane)
{
- var title = pane.title();
+ var title = pane._title;
this.appendTab(title, title, pane);
if (pane._toolbar)
pane.element.insertBefore(pane._toolbar.element, pane.element.firstChild);

Powered by Google App Engine
This is Rietveld 408576698