Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2152823002: Fix LayoutInline::visualOverflowRect() with outline in non-standard mode (Closed)

Created:
4 years, 5 months ago by Xianzhu
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Fix LayoutInline::visualOverflowRect() with outline in non-standard mode In non-standard mode, LayoutInline::linesVisualOverflowBoundingBox() doesn't necessarily cover outline rects of line boxes because we treat the line height differently when a line contains replaced elements in LayoutBlock::minLineHeightForReplacedObject(). BUG=626992 TEST=paint/invalidation/outline-containing-image-in-non-standard-mode.html Review-Url: https://codereview.chromium.org/2134413002 Cr-Commit-Position: refs/heads/master@{#404869} Committed: https://chromium.googlesource.com/chromium/src/+/7d6c4cd3cb59d246011cc3301e89fb9bafe37609

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Xianzhu
4 years, 5 months ago (2016-07-14 16:54:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7d6c4cd3cb59d246011cc3301e89fb9bafe37609.

Powered by Google App Engine
This is Rietveld 408576698