Fix LayoutInline::visualOverflowRect() with outline in non-standard mode

Fix LayoutInline::visualOverflowRect() with outline in non-standard mode

In non-standard mode, LayoutInline::linesVisualOverflowBoundingBox()
doesn't necessarily cover outline rects of line boxes because we treat
the line height differently when a line contains replaced elements
in LayoutBlock::minLineHeightForReplacedObject().

BUG=626992
TEST=paint/invalidation/outline-containing-image-in-non-standard-mode.html

Committed: https://crrev.com/b62027f56fdb4906393fe60105d33194e907624a
Cr-Commit-Position: refs/heads/master@{#404869}

[Xianzhu, 2016-07-11 23:00:15]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2016-07-11 23:20:24]

How about we also try to delete the quirks mode for outline?

[chrishtr, 2016-07-11 23:22:04]

lgtm

[Xianzhu, 2016-07-11 23:27:25]

On 2016/07/11 23:20:24, chrishtr wrote:
> How about we also try to delete the quirks mode for outline?

The root cause is not about quirks mode for outline, but because the different
line height of lines containing replaced elements, causing the optimization of
LayoutInline::addOutlinesForChildrenAndContinuations() not applicable to quirks
mode.

[Xianzhu, 2016-07-11 23:29:03]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-07-11 23:30:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 01:07:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 01:07:09]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2016-07-12 18:07:12]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-07-12 18:07:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2134413002/#ps20001
(title: "NeedsRebaseline")

[commit-bot: I haz the power, 2016-07-12 18:09:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 18:24:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 18:24:24]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-07-12 18:24:59]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-07-12 18:26:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 21:28:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 21:28:27]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-07-12 22:01:53]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-07-12 22:04:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 01:11:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 01:12:18]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 01:12:52]

Description was changed from

==========
Fix LayoutInline::visualOverflowRect() with outline in non-standard mode

In non-standard mode, LayoutInline::linesVisualOverflowBoundingBox()
doesn't necessarily cover outline rects of line boxes because we treat
the line height differently when a line contains replaced elements
in LayoutBlock::minLineHeightForReplacedObject().

BUG=626992
TEST=paint/invalidation/outline-containing-image-in-non-standard-mode.html
==========

to

==========
Fix LayoutInline::visualOverflowRect() with outline in non-standard mode

In non-standard mode, LayoutInline::linesVisualOverflowBoundingBox()
doesn't necessarily cover outline rects of line boxes because we treat
the line height differently when a line contains replaced elements
in LayoutBlock::minLineHeightForReplacedObject().

BUG=626992
TEST=paint/invalidation/outline-containing-image-in-non-standard-mode.html

Committed: https://crrev.com/b62027f56fdb4906393fe60105d33194e907624a
Cr-Commit-Position: refs/heads/master@{#404869}
==========

[commit-bot: I haz the power, 2016-07-13 01:12:53]

Patchset 2 (id:??) landed as
https://crrev.com/b62027f56fdb4906393fe60105d33194e907624a
Cr-Commit-Position: refs/heads/master@{#404869}