Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1840)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/xcode_writer.h

Issue 2152413002: GN: don't write separate files for non-binary targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/visual_studio_writer.cc ('k') | tools/gn/xcode_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/xcode_writer.h
diff --git a/tools/gn/xcode_writer.h b/tools/gn/xcode_writer.h
index 8c4e3040a0932af290c44a27b57cefa650a5c66f..5148788e662205ea9b6cef660ddd9845d0510ea0 100644
--- a/tools/gn/xcode_writer.h
+++ b/tools/gn/xcode_writer.h
@@ -48,7 +48,7 @@ class XcodeWriter {
const std::string& ninja_extra_args,
const std::string& dir_filters_string,
const BuildSettings* build_settings,
- Builder* builder,
+ const Builder& builder,
Err* err);
private:
« no previous file with comments | « tools/gn/visual_studio_writer.cc ('k') | tools/gn/xcode_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698