Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: tools/gn/xcode_writer.h

Issue 2152413002: GN: don't write separate files for non-binary targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/gn/visual_studio_writer.cc ('k') | tools/gn/xcode_writer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_XCODE_WRITER_H_ 5 #ifndef TOOLS_GN_XCODE_WRITER_H_
6 #define TOOLS_GN_XCODE_WRITER_H_ 6 #define TOOLS_GN_XCODE_WRITER_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 #include <map> 9 #include <map>
10 #include <memory> 10 #include <memory>
(...skipping 30 matching lines...) Expand all
41 // |ninja_extra_args| are additional arguments to pass to ninja invocation 41 // |ninja_extra_args| are additional arguments to pass to ninja invocation
42 // (can be used to increase limit of concurrent processes when using goma). 42 // (can be used to increase limit of concurrent processes when using goma).
43 // |dir_filters_string| is optional semicolon-separated list of label patterns 43 // |dir_filters_string| is optional semicolon-separated list of label patterns
44 // used to limit the set of generated projects. Only matching targets will be 44 // used to limit the set of generated projects. Only matching targets will be
45 // included to the workspace. On failure will populate |err| and return false. 45 // included to the workspace. On failure will populate |err| and return false.
46 static bool RunAndWriteFiles(const std::string& workspace_name, 46 static bool RunAndWriteFiles(const std::string& workspace_name,
47 const std::string& root_target_name, 47 const std::string& root_target_name,
48 const std::string& ninja_extra_args, 48 const std::string& ninja_extra_args,
49 const std::string& dir_filters_string, 49 const std::string& dir_filters_string,
50 const BuildSettings* build_settings, 50 const BuildSettings* build_settings,
51 Builder* builder, 51 const Builder& builder,
52 Err* err); 52 Err* err);
53 53
54 private: 54 private:
55 XcodeWriter(const std::string& name); 55 XcodeWriter(const std::string& name);
56 ~XcodeWriter(); 56 ~XcodeWriter();
57 57
58 // Filters the list of targets to only return the targets with artifacts 58 // Filters the list of targets to only return the targets with artifacts
59 // usable from Xcode (mostly application bundles). On failure populate |err| 59 // usable from Xcode (mostly application bundles). On failure populate |err|
60 // and return false. 60 // and return false.
61 static bool FilterTargets(const BuildSettings* build_settings, 61 static bool FilterTargets(const BuildSettings* build_settings,
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 void WriteWorkspaceContent(std::ostream& out); 93 void WriteWorkspaceContent(std::ostream& out);
94 void WriteProjectContent(std::ostream& out, PBXProject* project); 94 void WriteProjectContent(std::ostream& out, PBXProject* project);
95 95
96 std::string name_; 96 std::string name_;
97 std::vector<std::unique_ptr<PBXProject>> projects_; 97 std::vector<std::unique_ptr<PBXProject>> projects_;
98 98
99 DISALLOW_COPY_AND_ASSIGN(XcodeWriter); 99 DISALLOW_COPY_AND_ASSIGN(XcodeWriter);
100 }; 100 };
101 101
102 #endif // TOOLS_GN_XCODE_WRITER_H_ 102 #endif // TOOLS_GN_XCODE_WRITER_H_
OLDNEW
« no previous file with comments | « tools/gn/visual_studio_writer.cc ('k') | tools/gn/xcode_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698