Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: tools/gn/settings.h

Issue 2152413002: GN: don't write separate files for non-binary targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/qt_creator_writer.cc ('k') | tools/gn/setup.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/settings.h
diff --git a/tools/gn/settings.h b/tools/gn/settings.h
index 919255136b5a643f35947ab01a581f10f41e80d7..91f641060f39f8240b1f85ce3e8ca8cacc10d6d4 100644
--- a/tools/gn/settings.h
+++ b/tools/gn/settings.h
@@ -39,6 +39,10 @@ class Settings {
const BuildSettings* build_settings() const { return build_settings_; }
+ // The actual Toolchain object pointer is not available on the settings
+ // object because it might not be resolved yet. Code running after the
+ // load is complete can ask the Builder for the Toolchain corresponding to
+ // this label.
const Label& toolchain_label() const { return toolchain_label_; }
void set_toolchain_label(const Label& l) { toolchain_label_ = l; }
« no previous file with comments | « tools/gn/qt_creator_writer.cc ('k') | tools/gn/setup.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698