tools/gn/setup.h - Issue 2152413002: GN: don't write separate files for non-binary targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/setup.h

Issue 2152413002: GN: don't write separate files for non-binary targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: typo Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/setup.h

diff --git a/tools/gn/setup.h b/tools/gn/setup.h

index 22e655745b1f745e2f584cfaf61b73b2fbc16026..45335bf5b0e66e5fa9ca0167383e0b507ac5ec5a 100644

--- a/tools/gn/setup.h

+++ b/tools/gn/setup.h

@@ -82,7 +82,7 @@ class Setup {

}

BuildSettings& build_settings() { return build_settings_; }

- Builder* builder() { return builder_.get(); }

+ Builder& builder() { return builder_; }

LoaderImpl* loader() { return loader_.get(); }

// Name of the file in the root build directory that contains the build

@@ -128,7 +128,7 @@ class Setup {

BuildSettings build_settings_;

scoped_refptr<LoaderImpl> loader_;

- scoped_refptr<Builder> builder_;

+ Builder builder_;

SourceFile root_build_file_;

« no previous file with comments | « tools/gn/settings.h ('k') | tools/gn/setup.cc » ('j') | no next file with comments »