Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: tools/gn/qt_creator_writer.cc

Issue 2152413002: GN: don't write separate files for non-binary targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/qt_creator_writer.h ('k') | tools/gn/settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/qt_creator_writer.cc
diff --git a/tools/gn/qt_creator_writer.cc b/tools/gn/qt_creator_writer.cc
index 96f247f5719a0a580fa874b37ce39bb6351b1e02..db0c9b86b31f83e3a3ef1494cbb6fd8f9ae29802 100644
--- a/tools/gn/qt_creator_writer.cc
+++ b/tools/gn/qt_creator_writer.cc
@@ -32,7 +32,7 @@ base::FilePath::CharType kDefinesFileSuffix[] = FILE_PATH_LITERAL(".config");
// static
bool QtCreatorWriter::RunAndWriteFile(const BuildSettings* build_settings,
- const Builder* builder,
+ const Builder& builder,
Err* err,
const std::string& root_target) {
base::FilePath project_dir =
@@ -60,7 +60,7 @@ bool QtCreatorWriter::RunAndWriteFile(const BuildSettings* build_settings,
}
QtCreatorWriter::QtCreatorWriter(const BuildSettings* build_settings,
- const Builder* builder,
+ const Builder& builder,
const base::FilePath& project_prefix,
const std::string& root_target_name)
: build_settings_(build_settings),
@@ -81,7 +81,7 @@ void QtCreatorWriter::CollectDeps(const Target* target) {
}
bool QtCreatorWriter::DiscoverTargets() {
- auto all_targets = builder_->GetAllResolvedTargets();
+ auto all_targets = builder_.GetAllResolvedTargets();
if (root_target_name_.empty()) {
targets_ = std::set<const Target*>(all_targets.begin(), all_targets.end());
@@ -160,7 +160,7 @@ void QtCreatorWriter::Run() {
for (const Target* target : targets_) {
if (target->toolchain()->label() !=
- builder_->loader()->GetDefaultToolchain())
+ builder_.loader()->GetDefaultToolchain())
continue;
HandleTarget(target);
}
« no previous file with comments | « tools/gn/qt_creator_writer.h ('k') | tools/gn/settings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698