Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: tools/gn/qt_creator_writer.h

Issue 2152413002: GN: don't write separate files for non-binary targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_writer.cc ('k') | tools/gn/qt_creator_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/qt_creator_writer.h
diff --git a/tools/gn/qt_creator_writer.h b/tools/gn/qt_creator_writer.h
index cea75fd18144e8296cb5d35d7f6c7d21f1879f0a..cb374049f409e030fd349f330eeda866a1a66ce4 100644
--- a/tools/gn/qt_creator_writer.h
+++ b/tools/gn/qt_creator_writer.h
@@ -19,13 +19,13 @@ class BuildSettings;
class QtCreatorWriter {
public:
static bool RunAndWriteFile(const BuildSettings* build_settings,
- const Builder* builder,
+ const Builder& builder,
Err* err,
const std::string& root_target);
private:
QtCreatorWriter(const BuildSettings* build_settings,
- const Builder* builder,
+ const Builder& builder,
const base::FilePath& project_prefix,
const std::string& root_target_name);
~QtCreatorWriter();
@@ -41,7 +41,7 @@ class QtCreatorWriter {
const std::set<std::string>& items);
const BuildSettings* build_settings_;
- const Builder* builder_;
+ const Builder& builder_;
base::FilePath project_prefix_;
std::string root_target_name_;
std::set<const Target*> targets_;
« no previous file with comments | « tools/gn/ninja_writer.cc ('k') | tools/gn/qt_creator_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698