Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
index 3c939662cb2b10c53a31cf267f8523dbe5ba1413..ca1cdc3fa35122253621b80b286e7a5d6faccffa 100644
--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
@@ -59,14 +59,14 @@ content::RenderProcessHost* WebrtcLoggingPrivateFunction::RphFromRequest(
// If |guest_process_id| is defined, directly use this id to find the
// corresponding RenderProcessHost.
if (request.guest_process_id.get())
- return content::RenderProcessHost::FromID(*request.guest_process_id.get());
+ return content::RenderProcessHost::FromID(*request.guest_process_id);
// Otherwise, use the |tab_id|. If there's no |tab_id| and no
// |guest_process_id|, we can't look up the RenderProcessHost.
if (!request.tab_id.get())
return NULL;
- int tab_id = *request.tab_id.get();
+ int tab_id = *request.tab_id;
content::WebContents* contents = NULL;
if (!ExtensionTabUtil::GetTabById(
tab_id, GetProfile(), true, NULL, NULL, &contents, NULL)) {
@@ -168,7 +168,7 @@ bool WebrtcLoggingPrivateSetMetaDataFunction::RunAsync() {
std::unique_ptr<MetaDataMap> meta_data(new MetaDataMap());
for (const MetaDataEntry& entry : params->meta_data)
- (*meta_data.get())[entry.key] = entry.value;
+ (*meta_data)[entry.key] = entry.value;
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, base::Bind(
&WebRtcLoggingHandlerHost::SetMetaData, webrtc_logging_handler_host,

Powered by Google App Engine
This is Rietveld 408576698