Pass validated URL to WebContentsObserver::DidFailProvidsionalLoad.

Pass validated URL to WebContentsObserver::DidFailProvidsionalLoad

We used to filter URL in DidFailProvisionalLoadWithError in WebContentsImpl
before r243208 and used to pass the filtered/validated url to
WCO::DidFailProvisionalLoad. Moving filtering to NavigatorImpl caused this
to change, this CL restores the behavior.

BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/552a93858258daa13c2497884eecfdc2594b1e25
Cr-Commit-Position: refs/heads/master@{#405556}

[lazyboy, 2016-07-13 23:51:52]

Description was changed from

==========
Cleanup: remove a GURL copy in WebContentsImpl.

We used to filter URL in DidFailProvisionalLoadWithError in WebContentsImpl
before r243208. Since we no longer do that in WebContentsImpl, |validated_url|
became obsolte.

BUG=None
Test=None, internal cleanup.
==========

to

==========
Cleanup: remove a GURL copy in WebContentsImpl.

We used to filter URL in DidFailProvisionalLoadWithError in WebContentsImpl
before r243208. Since we no longer do that in WebContentsImpl, |validated_url|
became obsolete.

BUG=None
Test=None, internal cleanup.
==========

[lazyboy, 2016-07-13 23:52:08]

lazyboy@chromium.org changed reviewers:
+ nasko@chromium.org

[nasko, 2016-07-14 00:39:22]

https://codereview.chromium.org/2151743002/diff/40001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/2151743002/diff/40001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:3232: params.url,
The validation has been moved to NavigatorImpl::DidFailProvisionalLoadWithError.
Shouldn't we still be passing the validated URL through? I agree the copy isn't
probably needed, but it looks at this point the filtering of the URL is lost :(.

[lazyboy, 2016-07-14 00:48:52]

https://codereview.chromium.org/2151743002/diff/40001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/2151743002/diff/40001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:3232: params.url,
On 2016/07/14 00:39:21, nasko wrote:
> The validation has been moved to
NavigatorImpl::DidFailProvisionalLoadWithError.
Right.
> Shouldn't we still be passing the validated URL through?
Maybe, we can additionally pass validated_url from NavigatorImpl to this
function?
 I agree the copy isn't
> probably needed, but it looks at this point the filtering of the URL is lost
:(.

[nasko, 2016-07-14 14:22:46]

https://codereview.chromium.org/2151743002/diff/40001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/2151743002/diff/40001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:3232: params.url,
On 2016/07/14 00:48:52, lazyboy wrote:
> On 2016/07/14 00:39:21, nasko wrote:
> > The validation has been moved to
> NavigatorImpl::DidFailProvisionalLoadWithError.
> Right.
> > Shouldn't we still be passing the validated URL through?
> Maybe, we can additionally pass validated_url from NavigatorImpl to this
> function?
>  I agree the copy isn't
> > probably needed, but it looks at this point the filtering of the URL is lost
> :(.
> 

Let's just modify the method to take the exact params needed instead of the
params struct. This way we can pass the validated URL and the 3 extra params
don't seem a big deal to me.

[lazyboy, 2016-07-14 17:18:43]

Description was changed from

==========
Cleanup: remove a GURL copy in WebContentsImpl.

We used to filter URL in DidFailProvisionalLoadWithError in WebContentsImpl
before r243208. Since we no longer do that in WebContentsImpl, |validated_url|
became obsolete.

BUG=None
Test=None, internal cleanup.
==========

to

==========
Cleanup: remove a GURL copy in WebContentsImpl.

We used to filter URL in DidFailProvisionalLoadWithError in WebContentsImpl
before r243208. Since we no longer do that in WebContentsImpl, |validated_url|
became obsolete.

BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[lazyboy, 2016-07-14 17:20:52]

Description was changed from

==========
Cleanup: remove a GURL copy in WebContentsImpl.

We used to filter URL in DidFailProvisionalLoadWithError in WebContentsImpl
before r243208. Since we no longer do that in WebContentsImpl, |validated_url|
became obsolete.

BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Pass validated URL to WebContentsObserver::DidFailProvidsionalLoad

We used to filter URL in DidFailProvisionalLoadWithError in WebContentsImpl
before r243208 and used to pass the filtered/validated url to
WCO::DidFailProvisionalLoad. Moving filtering to NavigatorImpl caused this
to change, this CL restores the behavior.

BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[lazyboy, 2016-07-14 17:23:41]

Done in patch set #5

[nasko, 2016-07-14 18:13:01]

Thanks! LGTM

[lazyboy, 2016-07-14 18:18:58]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 18:19:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 19:33:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 19:33:22]

Dry run: This issue passed the CQ dry run.

[lazyboy, 2016-07-14 20:31:51]

The CQ bit was checked by lazyboy@chromium.org

[commit-bot: I haz the power, 2016-07-14 20:32:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 20:38:53]

Description was changed from

==========
Pass validated URL to WebContentsObserver::DidFailProvidsionalLoad

We used to filter URL in DidFailProvisionalLoadWithError in WebContentsImpl
before r243208 and used to pass the filtered/validated url to
WCO::DidFailProvisionalLoad. Moving filtering to NavigatorImpl caused this
to change, this CL restores the behavior.

BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Pass validated URL to WebContentsObserver::DidFailProvidsionalLoad

We used to filter URL in DidFailProvisionalLoadWithError in WebContentsImpl
before r243208 and used to pass the filtered/validated url to
WCO::DidFailProvisionalLoad. Moving filtering to NavigatorImpl caused this
to change, this CL restores the behavior.

BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-07-14 20:38:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-14 20:38:56]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 20:41:32]

Description was changed from

==========
Pass validated URL to WebContentsObserver::DidFailProvidsionalLoad

We used to filter URL in DidFailProvisionalLoadWithError in WebContentsImpl
before r243208 and used to pass the filtered/validated url to
WCO::DidFailProvisionalLoad. Moving filtering to NavigatorImpl caused this
to change, this CL restores the behavior.

BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Pass validated URL to WebContentsObserver::DidFailProvidsionalLoad

We used to filter URL in DidFailProvisionalLoadWithError in WebContentsImpl
before r243208 and used to pass the filtered/validated url to
WCO::DidFailProvisionalLoad. Moving filtering to NavigatorImpl caused this
to change, this CL restores the behavior.

BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/552a93858258daa13c2497884eecfdc2594b1e25
Cr-Commit-Position: refs/heads/master@{#405556}
==========

[commit-bot: I haz the power, 2016-07-14 20:41:33]

Patchset 5 (id:??) landed as
https://crrev.com/552a93858258daa13c2497884eecfdc2594b1e25
Cr-Commit-Position: refs/heads/master@{#405556}