Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2151743002: Pass validated URL to WebContentsObserver::DidFailProvidsionalLoad. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl format Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 8facc1cce53b243076e164dd366112ca66a89ed4..a9bb2ae9a77e2693e017881f3a95994fabf76048 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -3225,15 +3225,14 @@ void WebContentsImpl::DidStartProvisionalLoad(
void WebContentsImpl::DidFailProvisionalLoadWithError(
RenderFrameHostImpl* render_frame_host,
- const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params) {
- GURL validated_url(params.url);
- FOR_EACH_OBSERVER(WebContentsObserver,
- observers_,
- DidFailProvisionalLoad(render_frame_host,
- validated_url,
- params.error_code,
- params.error_description,
- params.was_ignored_by_handler));
+ const GURL& validated_url,
+ int error_code,
+ const base::string16& error_description,
+ bool was_ignored_by_handler) {
+ FOR_EACH_OBSERVER(
+ WebContentsObserver, observers_,
+ DidFailProvisionalLoad(render_frame_host, validated_url, error_code,
+ error_description, was_ignored_by_handler));
FrameTreeNode* ftn = render_frame_host->frame_tree_node();
BrowserAccessibilityManager* manager =
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698