Pass validated URL to WebContentsObserver::DidFailProvidsionalLoad.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <stddef.h>
 
 #include <cmath>
 #include <utility>
@@ skipping 3208 matching lines @@
     BrowserAccessibilityManager* manager =
         ftn->current_frame_host()->browser_accessibility_manager();
     if (manager)
       manager->UserIsReloading();
   }
 }
 
 void WebContentsImpl::DidFailProvisionalLoadWithError(
     RenderFrameHostImpl* render_frame_host,
     const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params) {
-  GURL validated_url(params.url);
   FOR_EACH_OBSERVER(WebContentsObserver,
                     observers_,
                     DidFailProvisionalLoad(render_frame_host,
-                                           validated_url,
+                                           params.url,

[nasko, 2016/07/14 00:39:21]

The validation has been moved to NavigatorImpl::DidFailProvisionalLoadWithError.
Shouldn't we still be passing the validated URL through? I agree the copy isn't
probably needed, but it looks at this point the filtering of the URL is lost :(.

[lazyboy, 2016/07/14 00:48:52]

Right.
Maybe, we can additionally pass validated_url from NavigatorImpl to this
function?
 I agree the copy isn't

[nasko, 2016/07/14 14:22:46]

Let's just modify the method to take the exact params needed instead of the
params struct. This way we can pass the validated URL and the 3 extra params
don't seem a big deal to me.

                                            params.error_code,
                                            params.error_description,
                                            params.was_ignored_by_handler));
 
   FrameTreeNode* ftn = render_frame_host->frame_tree_node();
   BrowserAccessibilityManager* manager =
       ftn->current_frame_host()->browser_accessibility_manager();
   if (manager)
     manager->NavigationFailed();
 }
@@ skipping 1930 matching lines @@
   for (RenderViewHost* render_view_host : render_view_host_set)
     render_view_host->OnWebkitPreferencesChanged();
 }
 
 void WebContentsImpl::SetJavaScriptDialogManagerForTesting(
     JavaScriptDialogManager* dialog_manager) {
   dialog_manager_ = dialog_manager;
 }
 
 }  // namespace content