Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 2151693003: Revert of [interpreter] Reduce dependencies in bytecodes.{h,cc} (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [interpreter] Reduce dependencies in bytecodes.{h,cc} (patchset #8 id:140001 of https://codereview.chromium.org/2135273002/ ) Reason for revert: Breaks the roll, possibly win gn: https://codereview.chromium.org/2148863002/ Original issue's description: > [interpreter] Reduce dependencies in bytecodes.{h,cc} > > This CL reduces the number of dependencies bytecodes.{h,cc} to facilitate > generating the bytecode peephole optimizer table during build. Specifically, > it avoids depending on v8_base. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/4edebb1cd870ae6c1359ad54f83e618e185883b1 > Cr-Commit-Position: refs/heads/master@{#37715} TBR=mstarzinger@chromium.org,rmcilroy@chromium.org,oth@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Committed: https://crrev.com/8aaa91efe6acd7579ba2f4455d3566e48d45a558 Cr-Commit-Position: refs/heads/master@{#37743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+528 lines, -690 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
M src/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/bytecode-graph-builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/extensions/ignition-statistics-extension.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-iterator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-iterator.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M src/interpreter/bytecode-array-writer.cc View 1 chunk +0 lines, -1 line 0 comments Download
D src/interpreter/bytecode-decoder.h View 1 chunk +0 lines, -43 lines 0 comments Download
D src/interpreter/bytecode-decoder.cc View 1 chunk +0 lines, -157 lines 0 comments Download
D src/interpreter/bytecode-flags.h View 1 chunk +0 lines, -42 lines 0 comments Download
D src/interpreter/bytecode-flags.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/bytecode-pipeline.h View 1 chunk +0 lines, -2 lines 0 comments Download
D src/interpreter/bytecode-register.h View 1 chunk +0 lines, -102 lines 0 comments Download
D src/interpreter/bytecode-register.cc View 1 chunk +0 lines, -155 lines 0 comments Download
M src/interpreter/bytecodes.h View 7 chunks +146 lines, -10 lines 0 comments Download
M src/interpreter/bytecodes.cc View 5 chunks +305 lines, -7 lines 0 comments Download
M src/interpreter/handler-table-builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/handler-table-builder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/runtime/runtime-interpreter.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -7 lines 0 comments Download
D test/unittests/interpreter/bytecode-decoder-unittest.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M test/unittests/interpreter/bytecodes-unittest.cc View 2 chunks +67 lines, -1 line 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [interpreter] Reduce dependencies in bytecodes.{h,cc}
4 years, 5 months ago (2016-07-14 07:29:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151693003/1
4 years, 5 months ago (2016-07-14 07:29:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 07:29:37 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 07:34:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8aaa91efe6acd7579ba2f4455d3566e48d45a558
Cr-Commit-Position: refs/heads/master@{#37743}

Powered by Google App Engine
This is Rietveld 408576698