Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2135273002: [interpreter] Reduce dependencies in bytecodes.{h,cc} (Closed)

Created:
4 years, 5 months ago by oth
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Reduce dependencies in bytecodes.{h,cc} This CL reduces the number of dependencies bytecodes.{h,cc} to facilitate generating the bytecode peephole optimizer table during build. Specifically, it avoids depending on v8_base. BUG=v8:4280 LOG=N Committed: https://crrev.com/4edebb1cd870ae6c1359ad54f83e618e185883b1 Cr-Commit-Position: refs/heads/master@{#37715}

Patch Set 1 #

Patch Set 2 : Add <string> to bytecodes.h. #

Patch Set 3 : Rebase #

Patch Set 4 : Minor clean-up. Move decoder unit test to own file. #

Patch Set 5 : Additional comment/clean-up. #

Patch Set 6 : Rebase. #

Patch Set 7 : Unbreak debug build. #

Patch Set 8 : Rebase. #

Patch Set 9 : Fix static const Register definitions for bot in roll for Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+686 lines, -527 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 2 chunks +6 lines, -0 lines 0 comments Download
M src/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/extensions/ignition-statistics-extension.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-array-iterator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-array-iterator.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M src/interpreter/bytecode-array-writer.cc View 1 chunk +1 line, -0 lines 0 comments Download
A src/interpreter/bytecode-decoder.h View 1 chunk +43 lines, -0 lines 0 comments Download
A src/interpreter/bytecode-decoder.cc View 1 2 3 1 chunk +157 lines, -0 lines 0 comments Download
A src/interpreter/bytecode-flags.h View 1 chunk +42 lines, -0 lines 0 comments Download
A src/interpreter/bytecode-flags.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-pipeline.h View 1 chunk +2 lines, -0 lines 0 comments Download
A src/interpreter/bytecode-register.h View 1 2 3 4 5 6 7 8 1 chunk +105 lines, -0 lines 0 comments Download
A src/interpreter/bytecode-register.cc View 1 2 3 4 5 6 7 8 1 chunk +149 lines, -0 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 2 3 4 7 chunks +9 lines, -145 lines 0 comments Download
M src/interpreter/bytecodes.cc View 5 6 5 chunks +7 lines, -305 lines 0 comments Download
M src/interpreter/handler-table-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/handler-table-builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -1 line 0 comments Download
M src/runtime/runtime-interpreter.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/v8.gyp View 1 2 3 4 5 6 7 1 chunk +7 lines, -1 line 0 comments Download
A test/unittests/interpreter/bytecode-decoder-unittest.cc View 1 2 3 1 chunk +86 lines, -0 lines 0 comments Download
M test/unittests/interpreter/bytecodes-unittest.cc View 1 2 3 2 chunks +1 line, -67 lines 0 comments Download
M test/unittests/unittests.gyp View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
oth
This is a prep step for a follow-on CL that generates the peephole optimization table ...
4 years, 5 months ago (2016-07-12 09:28:06 UTC) #7
rmcilroy
LGTM, thanks.
4 years, 5 months ago (2016-07-13 10:54:39 UTC) #8
Michael Starzinger
LGTM (rubber-stamp of "compiler", didn't look at the rest).
4 years, 5 months ago (2016-07-13 10:56:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135273002/120001
4 years, 5 months ago (2016-07-13 11:48:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/20646)
4 years, 5 months ago (2016-07-13 11:51:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2135273002/140001
4 years, 5 months ago (2016-07-13 13:48:46 UTC) #16
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 5 months ago (2016-07-13 13:58:08 UTC) #18
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/4edebb1cd870ae6c1359ad54f83e618e185883b1 Cr-Commit-Position: refs/heads/master@{#37715}
4 years, 5 months ago (2016-07-13 14:01:12 UTC) #20
Michael Achenbach
4 years, 5 months ago (2016-07-14 07:29:06 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2151693003/ by machenbach@chromium.org.

The reason for reverting is: Breaks the roll, possibly win gn:
https://codereview.chromium.org/2148863002/.

Powered by Google App Engine
This is Rietveld 408576698