src/objects.cc - Issue 2151693003: Revert of [interpreter] Reduce dependencies in bytecodes.{h,cc}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 2151693003: Revert of [interpreter] Reduce dependencies in bytecodes.{h,cc} (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 28b1efb5cf5ecb7e8a09f04335bcc1fc372bb301..01c2e1a4c99f9c424af9bf567d331cb0ca9df11a 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -38,7 +38,6 @@

#include "src/ic/ic.h"

#include "src/identity-map.h"

#include "src/interpreter/bytecode-array-iterator.h"

-#include "src/interpreter/bytecode-decoder.h"

#include "src/interpreter/interpreter.h"

#include "src/isolate-inl.h"

#include "src/keys.h"

@@ -14406,8 +14405,7 @@

const uint8_t* current_address = base_address + iterator.current_offset();

os << reinterpret_cast<const void*>(current_address) << " @ "

<< std::setw(4) << iterator.current_offset() << " : ";

- interpreter::BytecodeDecoder::Decode(os, current_address,

- parameter_count());

+ interpreter::Bytecodes::Decode(os, current_address, parameter_count());

if (interpreter::Bytecodes::IsJump(iterator.current_bytecode())) {

const void* jump_target = base_address + iterator.GetJumpTargetOffset();

os << " (" << jump_target << " @ " << iterator.GetJumpTargetOffset()

« no previous file with comments | « src/interpreter/interpreter-assembler.h ('k') | src/runtime/runtime-interpreter.cc » ('j') | no next file with comments »