Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2151503003: Make sure a test cannot be listed twice for one builder. (Closed)

Created:
4 years, 5 months ago by M-A Ruel
Modified:
4 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure a test cannot be listed twice for one builder. This check is now made at presubmit time, preventing hard to debug failure on the infrastructure. The failure mode is not obvious, the recipe throw an exception at trigger time and this is hard to diagnose. This fixes the problem before this is even sent to run as a try job. Tested manually. R=thakis@chromium.org BUG=626766 Committed: https://crrev.com/1e0384f82f2670e949e59556925978118246be92 Cr-Commit-Position: refs/heads/master@{#405194}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M testing/buildbot/manage.py View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
M-A Ruel
4 years, 5 months ago (2016-07-13 15:33:14 UTC) #1
Nico
lgtm
4 years, 5 months ago (2016-07-13 15:49:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151503003/1
4 years, 5 months ago (2016-07-13 15:51:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 16:54:38 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 16:57:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e0384f82f2670e949e59556925978118246be92
Cr-Commit-Position: refs/heads/master@{#405194}

Powered by Google App Engine
This is Rietveld 408576698