Make sure a test cannot be listed twice for one builder.

testing/buildbot/manage.py

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Toolbox to manage all the json files in this directory.
 
 It can reformat them in their canonical format or ensures they are well
 formatted.
 """
@@ skipping 206 matching lines @@
       raise Error('%s: %s is broken: %s' % (filename, builder, data))
     if 'gtest_tests' not in data:
       continue
     if not isinstance(data['gtest_tests'], list):
       raise Error(
           '%s: %s is broken: %s' % (filename, builder, data['gtest_tests']))
     if not all(isinstance(g, dict) for g in data['gtest_tests']):
       raise Error(
           '%s: %s is broken: %s' % (filename, builder, data['gtest_tests']))
 
+    seen = set()
     for d in data['gtest_tests']:
       if (d['test'] not in ninja_targets and
           d['test'] not in SKIP_GN_ISOLATE_MAP_TARGETS):
         raise Error('%s: %s / %s is not listed in gn_isolate_map.pyl.' %
                     (filename, builder, d['test']))
       elif d['test'] in ninja_targets:
         ninja_targets_seen.add(d['test'])
 
+      name = d.get('name', d['test'])
+      if name in seen:
+        raise Error('%s: %s / %s is listed multiple times.' %
+                    (filename, builder, name))
+      seen.add(name)
+
     config[builder]['gtest_tests'] = sorted(
         data['gtest_tests'], key=lambda x: x['test'])
 
     # The trick here is that process_builder_remaining() is called before
     # process_builder_convert() so tests_location can be used to know how many
     # tests were converted.
     if mode in ('convert', 'remaining'):
       process_builder_remaining(data, filename, builder, tests_location)
     if mode == 'convert':
       process_builder_convert(data, test_name)
@@ skipping 139 matching lines @@
     elif args.mode == 'remaining':
       print_remaining(args.test_name, tests_location)
     return result
   except Error as e:
     sys.stderr.write('%s\n' % e)
     return 1
 
 
 if __name__ == "__main__":
   sys.exit(main())