Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: testing/buildbot/manage.py

Issue 2151503003: Make sure a test cannot be listed twice for one builder. (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/buildbot/manage.py
diff --git a/testing/buildbot/manage.py b/testing/buildbot/manage.py
index cb4450349d5ab9beb03605e53c250c1fa71bc7c8..2f6e1992398b72cda1d27b2a9f2a3a6c5874cec4 100755
--- a/testing/buildbot/manage.py
+++ b/testing/buildbot/manage.py
@@ -224,6 +224,7 @@ def process_file(mode, test_name, tests_location, filepath, ninja_targets,
raise Error(
'%s: %s is broken: %s' % (filename, builder, data['gtest_tests']))
+ seen = set()
for d in data['gtest_tests']:
if (d['test'] not in ninja_targets and
d['test'] not in SKIP_GN_ISOLATE_MAP_TARGETS):
@@ -232,6 +233,12 @@ def process_file(mode, test_name, tests_location, filepath, ninja_targets,
elif d['test'] in ninja_targets:
ninja_targets_seen.add(d['test'])
+ name = d.get('name', d['test'])
+ if name in seen:
+ raise Error('%s: %s / %s is listed multiple times.' %
+ (filename, builder, name))
+ seen.add(name)
+
config[builder]['gtest_tests'] = sorted(
data['gtest_tests'], key=lambda x: x['test'])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698