Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2854)

Unified Diff: chrome/browser/resources/settings/site_settings/media_picker.html

Issue 2151383002: MD Settings: Use <button class="dropdown-item"> for drop-down options. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/media_picker.html
diff --git a/chrome/browser/resources/settings/site_settings/media_picker.html b/chrome/browser/resources/settings/site_settings/media_picker.html
index 733827e255c8a5bc8c3c435522358817625eae4d..450faf5f63bba37fc97dac9ccb843aad73d44df1 100644
--- a/chrome/browser/resources/settings/site_settings/media_picker.html
+++ b/chrome/browser/resources/settings/site_settings/media_picker.html
@@ -16,10 +16,10 @@
attr-for-selected="media-picker-value"
on-iron-activate="onMediaPickerActivate_">
<template is="dom-repeat" items="[[devices]]">
- <div class="dropdown-item" role="option"
+ <button class="dropdown-item" role="option"
media-picker-value$="[[item.id]]">
[[item.name]]
- </div>
+ </button>
</template>
</paper-listbox>
</paper-dropdown-menu>

Powered by Google App Engine
This is Rietveld 408576698