Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2151023003: Revert of Expand _01 half<->float limitation to _finite. Simplify. (Closed)

Created:
4 years, 5 months ago by mtklein
Modified:
4 years, 5 months ago
Reviewers:
msarett, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Expand _01 half<->float limitation to _finite. Simplify. (patchset #7 id:120001 of https://codereview.chromium.org/2145663003/ ) Reason for revert: Unit tests fail on Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast Original issue's description: > Expand _01 half<->float limitation to _finite. Simplify. > > It's become clear we need to sometimes deal with values <0 or >1. > I'm not yet convinced we care about NaN or +-inf. > > We had some fairly clever tricks and optimizations here for NEON > and SSE. I've thrown them out in favor of a single implementation. > If we find the specializations mattered, we can certainly figure out > how to extend them to this new range/domain. > > This happens to add a vectorized float -> half for ARMv7, which was > missing from the _01 version. (The SSE strategy was not portable to > platforms that flush denorm floats to zero.) > > I've tested the full float range for FloatToHalf on my desktop and a 5x. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2145663003 > CQ_INCLUDE_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot > > Committed: https://skia.googlesource.com/skia/+/3296bee70d074bb8094b3229dbe12fa016657e90 TBR=msarett@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/64bbad360f30930befafee1bdefe4ad89f130dac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -153 lines) Patch
M src/core/SkBitmap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkHalf.h View 4 chunks +66 lines, -41 lines 0 comments Download
M src/core/SkLinearBitmapPipeline_sample.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkMipMap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkSpanProcs.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkXfermodeF16.cpp View 7 chunks +21 lines, -21 lines 0 comments Download
M src/effects/gradients/Sk4fGradientPriv.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/opts/SkNx_neon.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/opts/SkNx_sse.h View 2 chunks +1 line, -29 lines 0 comments Download
M tests/Float16Test.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M tests/SkNxTest.cpp View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein
Created Revert of Expand _01 half<->float limitation to _finite. Simplify.
4 years, 5 months ago (2016-07-14 19:02:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151023003/1
4 years, 5 months ago (2016-07-14 19:02:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/64bbad360f30930befafee1bdefe4ad89f130dac
4 years, 5 months ago (2016-07-14 19:03:09 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 19:03:11 UTC) #6
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698