Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 2149993002: [Devtools] Fixed minor regression with network log view padding (Closed)

Created:
4 years, 5 months ago by allada
Modified:
4 years, 5 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed minor regression with network log view padding This fixes a regression caused from https://codereview.chromium.org/2118663002 where it would always show the padding designed for "Large View" in the spacers of timeline. BUG=628091 R=lushnikov Committed: https://crrev.com/d6e42b7cc69c5ccd89d3bd5a1419f2af0d3d7327 Cr-Commit-Position: refs/heads/master@{#405537}

Patch Set 1 #

Patch Set 2 : Fixed regression with network timing dividers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 1 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
allada
PTL
4 years, 5 months ago (2016-07-14 17:05:41 UTC) #2
lushnikov
lgtm
4 years, 5 months ago (2016-07-14 18:06:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149993002/20001
4 years, 5 months ago (2016-07-14 18:07:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 19:25:12 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 19:25:15 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 19:26:54 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6e42b7cc69c5ccd89d3bd5a1419f2af0d3d7327
Cr-Commit-Position: refs/heads/master@{#405537}

Powered by Google App Engine
This is Rietveld 408576698