Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2149993002: [Devtools] Fixed minor regression with network log view padding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed regression with network timing dividers Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
index 0355e2d9778b83c2fb362f71d503ee25b4e9c54b..9a3f4deae33dd2dff40834a2079ef2f9beed3b96 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
@@ -21,7 +21,8 @@ WebInspector.NetworkLogViewColumns = function(networkLogView, networkLogLargeRow
columnsVisibility[columnId] = savedColumnsVisibility.hasOwnProperty(columnId) ? savedColumnsVisibility[columnId] : defaultColumnsVisibility[columnId];
this._columnsVisibilitySetting.set(columnsVisibility);
- networkLogLargeRowsSetting.addChangeListener(this._updateRowsSize, this);
+ this._networkLogLargeRowsSetting = networkLogLargeRowsSetting;
+ this._networkLogLargeRowsSetting.addChangeListener(this._updateRowsSize, this);
/** @type {!Array<{time: number, element: !Element}>} */
this._eventDividers = [];
@@ -271,6 +272,8 @@ WebInspector.NetworkLogViewColumns.prototype = {
this._dataGrid.addEventListener(WebInspector.DataGrid.Events.ColumnsResized, this.updateDividersIfNeeded, this);
+ this._updateRowsSize();
+
return this._dataGrid;
},
@@ -608,11 +611,8 @@ WebInspector.NetworkLogViewColumns.prototype = {
this._timelineGrid.showEventDividers();
},
- /**
- * @param {!WebInspector.Event} event
- */
- _updateRowsSize: function(event)
+ _updateRowsSize: function()
{
- this._timelineGrid.element.classList.toggle("small", !event.data);
+ this._timelineGrid.element.classList.toggle("small", !this._networkLogLargeRowsSetting.get());
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698