ui/views/bubble/bubble_dialog_delegate_unittest.cc - Issue 2148963002: BubbleFrameView: add top padding even when close button is hidden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/bubble/bubble_dialog_delegate_unittest.cc

Issue 2148963002: BubbleFrameView: add top padding even when close button is hidden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix CrOS build Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc ('k') | ui/views/bubble/bubble_frame_view.h » ('j') | ui/views/bubble/bubble_frame_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/bubble/bubble_dialog_delegate_unittest.cc

diff --git a/ui/views/bubble/bubble_dialog_delegate_unittest.cc b/ui/views/bubble/bubble_dialog_delegate_unittest.cc

index ea787f8d0944d097d18d37a8e788500dc10983c8..b72ee4943f7825205ef28f8c1548203b2c430b17 100644

--- a/ui/views/bubble/bubble_dialog_delegate_unittest.cc

+++ b/ui/views/bubble/bubble_dialog_delegate_unittest.cc

@@ -11,7 +11,7 @@

#include "ui/base/hit_test.h"

#include "ui/events/event_utils.h"

#include "ui/views/bubble/bubble_frame_view.h"

-#include "ui/views/controls/button/label_button.h"

+#include "ui/views/controls/button/image_button.h"

#include "ui/views/test/test_widget_observer.h"

#include "ui/views/test/views_test_base.h"

#include "ui/views/widget/widget.h"

@@ -321,7 +321,7 @@ TEST_F(BubbleDialogDelegateTest, CloseMethods) {

BubbleDialogDelegateView::CreateBubble(bubble_delegate);

bubble_widget->Show();

BubbleFrameView* frame_view = bubble_delegate->GetBubbleFrameView();

- LabelButton* close_button = frame_view->close_;

+ ImageButton* close_button = frame_view->close_;

ASSERT_TRUE(close_button);

frame_view->ButtonPressed(

close_button,