Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: ui/views/bubble/bubble_dialog_delegate_unittest.cc

Issue 2148963002: BubbleFrameView: add top padding even when close button is hidden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix CrOS build Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/bubble/bubble_dialog_delegate.h" 5 #include "ui/views/bubble/bubble_dialog_delegate.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/i18n/rtl.h" 9 #include "base/i18n/rtl.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "ui/base/hit_test.h" 11 #include "ui/base/hit_test.h"
12 #include "ui/events/event_utils.h" 12 #include "ui/events/event_utils.h"
13 #include "ui/views/bubble/bubble_frame_view.h" 13 #include "ui/views/bubble/bubble_frame_view.h"
14 #include "ui/views/controls/button/label_button.h" 14 #include "ui/views/controls/button/image_button.h"
15 #include "ui/views/test/test_widget_observer.h" 15 #include "ui/views/test/test_widget_observer.h"
16 #include "ui/views/test/views_test_base.h" 16 #include "ui/views/test/views_test_base.h"
17 #include "ui/views/widget/widget.h" 17 #include "ui/views/widget/widget.h"
18 #include "ui/views/widget/widget_observer.h" 18 #include "ui/views/widget/widget_observer.h"
19 19
20 namespace views { 20 namespace views {
21 21
22 namespace { 22 namespace {
23 23
24 class TestBubbleDialogDelegateView : public BubbleDialogDelegateView { 24 class TestBubbleDialogDelegateView : public BubbleDialogDelegateView {
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 } 314 }
315 315
316 { 316 {
317 std::unique_ptr<Widget> anchor_widget(CreateTestWidget()); 317 std::unique_ptr<Widget> anchor_widget(CreateTestWidget());
318 TestBubbleDialogDelegateView* bubble_delegate = 318 TestBubbleDialogDelegateView* bubble_delegate =
319 new TestBubbleDialogDelegateView(anchor_widget->GetContentsView()); 319 new TestBubbleDialogDelegateView(anchor_widget->GetContentsView());
320 Widget* bubble_widget = 320 Widget* bubble_widget =
321 BubbleDialogDelegateView::CreateBubble(bubble_delegate); 321 BubbleDialogDelegateView::CreateBubble(bubble_delegate);
322 bubble_widget->Show(); 322 bubble_widget->Show();
323 BubbleFrameView* frame_view = bubble_delegate->GetBubbleFrameView(); 323 BubbleFrameView* frame_view = bubble_delegate->GetBubbleFrameView();
324 LabelButton* close_button = frame_view->close_; 324 ImageButton* close_button = frame_view->close_;
325 ASSERT_TRUE(close_button); 325 ASSERT_TRUE(close_button);
326 frame_view->ButtonPressed( 326 frame_view->ButtonPressed(
327 close_button, 327 close_button,
328 ui::MouseEvent(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(), 328 ui::MouseEvent(ui::ET_MOUSE_PRESSED, gfx::Point(), gfx::Point(),
329 ui::EventTimeForNow(), ui::EF_NONE, ui::EF_NONE)); 329 ui::EventTimeForNow(), ui::EF_NONE, ui::EF_NONE));
330 EXPECT_TRUE(bubble_widget->IsClosed()); 330 EXPECT_TRUE(bubble_widget->IsClosed());
331 } 331 }
332 } 332 }
333 333
334 } // namespace views 334 } // namespace views
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698