chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc - Issue 2148963002: BubbleFrameView: add top padding even when close button is hidden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc

Issue 2148963002: BubbleFrameView: add top padding even when close button is hidden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix CrOS build Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc

index 487df5f782be292f799f2736f60cbcead98877d4..69e07b939b0b29b3082e545ae38211ee24073de8 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc

@@ -19,7 +19,7 @@

#include "ui/views/border.h"

#include "ui/views/bubble/bubble_border.h"

#include "ui/views/bubble/bubble_frame_view.h"

-#include "ui/views/controls/button/label_button.h"

+#include "ui/views/controls/button/image_button.h"

#include "ui/views/layout/fill_layout.h"

#include "ui/views/widget/widget.h"

#include "ui/views/window/client_view.h"

@@ -168,7 +168,7 @@ class AppListDialogContainer : public BaseDialogContainer,

}

- views::LabelButton* close_button_;

+ views::ImageButton* close_button_;

DISALLOW_COPY_AND_ASSIGN(AppListDialogContainer);

};

« no previous file with comments | « no previous file | ui/views/bubble/bubble_dialog_delegate_unittest.cc » ('j') | ui/views/bubble/bubble_frame_view.h » ('J')