Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2148363003: mash: Cleanup ash test strings and resources. (Closed)

Created:
4 years, 5 months ago by msw
Modified:
4 years, 5 months ago
Reviewers:
James Cook, sky
CC:
chromium-reviews, kalyank, jam, sadrul, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Cleanup ash test strings and resources. Make ResourceBundle::IsScaleFactorSupported public. (check when loading ash shell/sysui/tests resources) Refactor GN's target for ash_test_strings.pak generation. (can be used to generate locale-specific ash string paks) Skip renaming of test string/resource paks for ash_sysui. Update some comments and TODOs. BUG=628715 TEST=No behavioral changes or regressions; automated tests. R=jamescook@chromium.org,sky@chromium.org Committed: https://crrev.com/d04d3ef32573a8276d11f293a9cfb6ff327f0461 Cr-Commit-Position: refs/heads/master@{#406144}

Patch Set 1 #

Patch Set 2 : More minor cleanup. #

Patch Set 3 : Add TODOS. #

Patch Set 4 : Cleanup patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -85 lines) Patch
M ash/mus/BUILD.gn View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ash/resources/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/content/client/shell_main_delegate.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M ash/strings/BUILD.gn View 1 2 3 1 chunk +32 lines, -21 lines 0 comments Download
M ash/sysui/BUILD.gn View 1 2 3 3 chunks +5 lines, -36 lines 0 comments Download
M ash/sysui/sysui_application.cc View 1 2 chunks +12 lines, -9 lines 0 comments Download
M ash/test/test_suite.cc View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M mash/test/mash_test_suite.cc View 1 1 chunk +5 lines, -8 lines 0 comments Download
M ui/base/resource/resource_bundle.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
msw
Hey James and Scott, please take a look; thanks! (James: ash/*. Scott: mash/*, ui/*)
4 years, 5 months ago (2016-07-18 20:29:51 UTC) #4
James Cook
LGTM
4 years, 5 months ago (2016-07-18 22:00:17 UTC) #9
sky
LGTM
4 years, 5 months ago (2016-07-18 22:01:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148363003/60001
4 years, 5 months ago (2016-07-18 23:05:18 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-18 23:43:25 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 23:43:57 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 23:45:40 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d04d3ef32573a8276d11f293a9cfb6ff327f0461
Cr-Commit-Position: refs/heads/master@{#406144}

Powered by Google App Engine
This is Rietveld 408576698