Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: ash/sysui/BUILD.gn

Issue 2148363003: mash: Cleanup ash test strings and resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup patch Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/strings/BUILD.gn ('k') | ash/sysui/sysui_application.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/sysui/BUILD.gn
diff --git a/ash/sysui/BUILD.gn b/ash/sysui/BUILD.gn
index f14fa2bd3056ae7a26e322bd1e4b0582f06cae3b..3b4ca6dcdb3d063c0572e41af4bd6d538bb24c49 100644
--- a/ash/sysui/BUILD.gn
+++ b/ash/sysui/BUILD.gn
@@ -6,7 +6,6 @@ import("//build/config/ui.gni")
import("//mojo/public/mojo_application.gni")
import("//mojo/public/mojo_application_manifest.gni")
import("//mojo/public/tools/bindings/mojom.gni")
-import("//tools/grit/repack.gni")
source_set("lib") {
sources = [
@@ -86,9 +85,9 @@ mojo_native_application("sysui") {
]
deps = [
":lib",
- ":resources_100",
- ":resources_200",
- ":resources_strings",
+ "//ash/resources:ash_test_resources_100_percent",
+ "//ash/resources:ash_test_resources_200_percent",
+ "//ash/strings:ash_test_strings",
"//services/shell/public/cpp",
]
@@ -97,40 +96,10 @@ mojo_native_application("sysui") {
"//services/ui",
]
+ # TODO: Load locale-specific strings and explicit resource dependencies.
resources = [
- "$root_out_dir/ash_resources_strings.pak",
- "$root_out_dir/ash_resources_100_percent.pak",
- "$root_out_dir/ash_resources_200_percent.pak",
- ]
-}
-
-#TODO(msw): Do not load 'test' resources (include sys lang?).
-repack("resources_strings") {
- sources = [
- "$root_out_dir/ash_test_strings.pak",
- ]
- output = "$root_out_dir/ash_resources_strings.pak"
- deps = [
- "//ash/strings:ash_test_strings",
- ]
-}
-
-repack("resources_100") {
- sources = [
"$root_out_dir/ash_test_resources_100_percent.pak",
- ]
- output = "$root_out_dir/ash_resources_100_percent.pak"
- deps = [
- "//ash/resources:ash_test_resources_100_percent",
- ]
-}
-
-repack("resources_200") {
- sources = [
"$root_out_dir/ash_test_resources_200_percent.pak",
- ]
- output = "$root_out_dir/ash_resources_200_percent.pak"
- deps = [
- "//ash/resources:ash_test_resources_200_percent",
+ "$root_out_dir/ash_test_strings.pak",
]
}
« no previous file with comments | « ash/strings/BUILD.gn ('k') | ash/sysui/sysui_application.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698