Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: ash/mus/BUILD.gn

Issue 2148363003: mash: Cleanup ash test strings and resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup patch Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/resources/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/mus/BUILD.gn
diff --git a/ash/mus/BUILD.gn b/ash/mus/BUILD.gn
index f9d57e62aef193002c6eaf3d5f66581f050a459a..2afe6181c4c411d5f71b22a83044ce30ab3f1201 100644
--- a/ash/mus/BUILD.gn
+++ b/ash/mus/BUILD.gn
@@ -138,7 +138,10 @@ mojo_application_manifest("manifest") {
source = "manifest.json"
}
+# TODO: Load resources at additional scales and load locale-specific strings.
+# TODO: Avoid duplication between Mash and Chrome pak files: crbug.com/628715.
repack("resources") {
+ output = "$root_out_dir/ash_mus_resources.pak"
sources = [
"$root_gen_dir/ash/mus/resources/ash_mus_resources_100_percent.pak",
"$root_gen_dir/ash/resources/ash_resources_100_percent.pak",
@@ -147,7 +150,6 @@ repack("resources") {
"$root_gen_dir/ui/strings/ui_strings_en-US.pak",
"$root_gen_dir/ui/views/resources/views_resources_100_percent.pak",
]
- output = "$root_out_dir/ash_mus_resources.pak"
deps = [
"//ash/mus/resources",
"//ash/resources",
« no previous file with comments | « no previous file | ash/resources/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698