Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2148243004: chrome::ShowTaskManager: refine return type to eliminate a downcast. (Closed)

Created:
4 years, 5 months ago by ncarter (slow)
Modified:
4 years, 4 months ago
Reviewers:
afakhry, Lei Zhang
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@triple_click_tm
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome::ShowTaskManager: refine return type to eliminate a downcast. BUG=614551 Committed: https://crrev.com/bb57d2cac517c51049f7cc38f24b89164a34e13f Cr-Commit-Position: refs/heads/master@{#407626}

Patch Set 1 #

Patch Set 2 : Fix mac compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M chrome/browser/task_management/task_manager_tester.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/browser_dialogs.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/browser_dialogs_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/browser_dialogs_views_mac.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
ncarter (slow)
Ahmed, please take a look.
4 years, 5 months ago (2016-07-14 20:38:41 UTC) #3
afakhry
LGTM!!
4 years, 5 months ago (2016-07-14 22:09:52 UTC) #7
ncarter (slow)
+thestig for chrome/ approval
4 years, 5 months ago (2016-07-14 22:10:41 UTC) #9
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-14 23:06:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148243004/20001
4 years, 4 months ago (2016-07-25 22:01:00 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-25 23:08:26 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 23:10:27 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bb57d2cac517c51049f7cc38f24b89164a34e13f
Cr-Commit-Position: refs/heads/master@{#407626}

Powered by Google App Engine
This is Rietveld 408576698