Issue 2148243004: chrome::ShowTaskManager: refine return type to eliminate a downcast.

Issue 2148243004: chrome::ShowTaskManager: refine return type to eliminate a downcast. (Closed)

Created:
4 years, 5 months ago by ncarter (slow)

Modified:
4 years, 4 months ago

Reviewers:
afakhry, Lei Zhang

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@triple_click_tm

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

chrome::ShowTaskManager: refine return type to eliminate a downcast. BUG=614551 Committed: https://crrev.com/bb57d2cac517c51049f7cc38f24b89164a34e13f Cr-Commit-Position: refs/heads/master@{#407626}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -11 lines)			Patch
M	chrome/browser/task_management/task_manager_tester.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/browser/ui/browser_dialogs.h	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/task_manager_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/browser_dialogs_views.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/browser_dialogs_views_mac.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Dependent Patchsets:

Total messages: 15 (8 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148243004/20001

4 years, 4 months ago (2016-07-25 22:01:00 UTC) #12

commit-bot: I haz the power

4 years, 4 months ago (2016-07-25 23:10:27 UTC) #15

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/bb57d2cac517c51049f7cc38f24b89164a34e13f
Cr-Commit-Position: refs/heads/master@{#407626}