Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: chrome/browser/ui/browser_dialogs.h

Issue 2148243004: chrome::ShowTaskManager: refine return type to eliminate a downcast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@triple_click_tm
Patch Set: Fix mac compile. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_management/task_manager_tester.cc ('k') | chrome/browser/ui/cocoa/task_manager_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_dialogs.h
diff --git a/chrome/browser/ui/browser_dialogs.h b/chrome/browser/ui/browser_dialogs.h
index c510deddf6fa0a63f3bde123801376bef2f9877e..65450766883c9ae5a599c6d8e2511772e19a2dad 100644
--- a/chrome/browser/ui/browser_dialogs.h
+++ b/chrome/browser/ui/browser_dialogs.h
@@ -54,8 +54,11 @@ class AuthChallengeInfo;
class URLRequest;
}
+namespace task_management {
+class TaskManagerTableModel;
+}
+
namespace ui {
-class TableModel;
class WebDialogDelegate;
}
@@ -72,7 +75,7 @@ extern const base::Feature kMacViewsWebUIDialogs;
// Shows or hides the Task Manager. |browser| can be NULL when called from Ash.
// Returns a pointer to the underlying TableModel, which can be ignored, or used
// for testing.
-ui::TableModel* ShowTaskManager(Browser* browser);
+task_management::TaskManagerTableModel* ShowTaskManager(Browser* browser);
void HideTaskManager();
#if !defined(OS_MACOSX)
@@ -132,7 +135,7 @@ void ShowBookmarkBubbleViewsAtPoint(const gfx::Point& anchor_point,
bool newly_bookmarked);
// Bridging methods that show/hide the toolkit-views based Task Manager on Mac.
-ui::TableModel* ShowTaskManagerViews(Browser* browser);
+task_management::TaskManagerTableModel* ShowTaskManagerViews(Browser* browser);
void HideTaskManagerViews();
// Notifies the old task manager with network bytes read events when the Mac
« no previous file with comments | « chrome/browser/task_management/task_manager_tester.cc ('k') | chrome/browser/ui/cocoa/task_manager_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698