TaskManager: when shown or activated, select the last active tab.

TaskManager: when shown or activated, select the last active tab.

Introduce a method, NewTaskManagerView::SelectTaskOfActiveTab, which
allows the selection model to be updated to match the main row
of a particular WebContents. Add plumbing from the NewTaskManagerView
down to the TaskProviders to support this lookup.

Rename NewTaskManagerView::ActivateFocusedTab for consistency and accuracy
(it's basically the inverse of the new function).

Replace the ScopedVector of TaskProviders with a std::vector of unique_ptrs,
since ScopedVector is deprecated.

BUG=614551
TEST=included browser_test

Committed: https://crrev.com/1824ae3ede49ac7e6cf6224d03e713fab8070c30
Cr-Commit-Position: refs/heads/master@{#409087}

[ncarter (slow), 2016-07-14 01:42:28]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 01:42:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 02:02:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 02:02:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[ncarter (slow), 2016-07-14 04:48:29]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 04:48:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 05:33:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 05:33:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ncarter (slow), 2016-07-25 22:50:41]

Description was changed from

==========
TaskManager: when shown or activated, select the last active tab.

BUG=614551
==========

to

==========
TaskManager: when shown or activated, select the last active tab.

Introduce a method, NewTaskManagerView::SelectTaskOfActiveTab, which
allows the selection model to be updated to match the main row
of a particular WebContents. Add plumbing from the NewTaskManagerView
down to the TaskProviders to support this lookup.

BUG=614551
==========

[ncarter (slow), 2016-07-25 22:52:26]

Description was changed from

==========
TaskManager: when shown or activated, select the last active tab.

Introduce a method, NewTaskManagerView::SelectTaskOfActiveTab, which
allows the selection model to be updated to match the main row
of a particular WebContents. Add plumbing from the NewTaskManagerView
down to the TaskProviders to support this lookup.

BUG=614551
==========

to

==========
TaskManager: when shown or activated, select the last active tab.

Introduce a method, NewTaskManagerView::SelectTaskOfActiveTab, which
allows the selection model to be updated to match the main row
of a particular WebContents. Add plumbing from the NewTaskManagerView
down to the TaskProviders to support this lookup.

Rename NewTaskManagerView::ActivateFocusedTab for consistency and accuracy (it's
basically the inverse of the new function).

Replace the ScopedVector of TaskProviders with a std::vector of unique_ptrs,
while we're touching it, since ScopedVector is deprecated.

BUG=614551
==========

[ncarter (slow), 2016-07-25 22:52:48]

Description was changed from

==========
TaskManager: when shown or activated, select the last active tab.

Introduce a method, NewTaskManagerView::SelectTaskOfActiveTab, which
allows the selection model to be updated to match the main row
of a particular WebContents. Add plumbing from the NewTaskManagerView
down to the TaskProviders to support this lookup.

Rename NewTaskManagerView::ActivateFocusedTab for consistency and accuracy (it's
basically the inverse of the new function).

Replace the ScopedVector of TaskProviders with a std::vector of unique_ptrs,
while we're touching it, since ScopedVector is deprecated.

BUG=614551
==========

to

==========
TaskManager: when shown or activated, select the last active tab.

Introduce a method, NewTaskManagerView::SelectTaskOfActiveTab, which
allows the selection model to be updated to match the main row
of a particular WebContents. Add plumbing from the NewTaskManagerView
down to the TaskProviders to support this lookup.

Rename NewTaskManagerView::ActivateFocusedTab for consistency and accuracy
(it's basically the inverse of the new function).

Replace the ScopedVector of TaskProviders with a std::vector of unique_ptrs,
since ScopedVector is deprecated.

BUG=614551
==========

[ncarter (slow), 2016-07-25 22:53:02]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[ncarter (slow), 2016-07-25 22:53:25]

Description was changed from

==========
TaskManager: when shown or activated, select the last active tab.

Introduce a method, NewTaskManagerView::SelectTaskOfActiveTab, which
allows the selection model to be updated to match the main row
of a particular WebContents. Add plumbing from the NewTaskManagerView
down to the TaskProviders to support this lookup.

Rename NewTaskManagerView::ActivateFocusedTab for consistency and accuracy
(it's basically the inverse of the new function).

Replace the ScopedVector of TaskProviders with a std::vector of unique_ptrs,
since ScopedVector is deprecated.

BUG=614551
==========

to

==========
TaskManager: when shown or activated, select the last active tab.

Introduce a method, NewTaskManagerView::SelectTaskOfActiveTab, which
allows the selection model to be updated to match the main row
of a particular WebContents. Add plumbing from the NewTaskManagerView
down to the TaskProviders to support this lookup.

Rename NewTaskManagerView::ActivateFocusedTab for consistency and accuracy
(it's basically the inverse of the new function).

Replace the ScopedVector of TaskProviders with a std::vector of unique_ptrs,
since ScopedVector is deprecated.


BUG=614551
TEST=included browser_test
==========

[ncarter (slow), 2016-07-25 22:53:37]

Description was changed from

==========
TaskManager: when shown or activated, select the last active tab.

Introduce a method, NewTaskManagerView::SelectTaskOfActiveTab, which
allows the selection model to be updated to match the main row
of a particular WebContents. Add plumbing from the NewTaskManagerView
down to the TaskProviders to support this lookup.

Rename NewTaskManagerView::ActivateFocusedTab for consistency and accuracy
(it's basically the inverse of the new function).

Replace the ScopedVector of TaskProviders with a std::vector of unique_ptrs,
since ScopedVector is deprecated.


BUG=614551
TEST=included browser_test
==========

to

==========
TaskManager: when shown or activated, select the last active tab.

Introduce a method, NewTaskManagerView::SelectTaskOfActiveTab, which
allows the selection model to be updated to match the main row
of a particular WebContents. Add plumbing from the NewTaskManagerView
down to the TaskProviders to support this lookup.

Rename NewTaskManagerView::ActivateFocusedTab for consistency and accuracy
(it's basically the inverse of the new function).

Replace the ScopedVector of TaskProviders with a std::vector of unique_ptrs,
since ScopedVector is deprecated.

BUG=614551
TEST=included browser_test
==========

[commit-bot: I haz the power, 2016-07-25 22:53:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ncarter (slow), 2016-07-25 22:54:06]

nick@chromium.org changed reviewers:
+ afakhry@chromium.org

[ncarter (slow), 2016-07-25 22:54:07]

ahmed: please review this

[commit-bot: I haz the power, 2016-07-26 00:03:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 00:03:06]

Dry run: This issue passed the CQ dry run.

[afakhry, 2016-07-26 00:06:14]

LGTM!!! Thanks!

[ncarter (slow), 2016-07-27 17:10:39]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 17:11:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 17:13:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 17:13:16]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[ncarter (slow), 2016-07-27 22:32:50]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 22:33:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 23:16:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 23:16:27]

Dry run: This issue passed the CQ dry run.

[ncarter (slow), 2016-07-28 17:09:33]

nick@chromium.org changed reviewers:
+ sky@chromium.org

[ncarter (slow), 2016-07-28 17:09:33]

+sky: please review new_task_manager_view* and the overall concept

[ncarter (slow), 2016-08-01 17:10:51]

sky: ping

[sky, 2016-08-01 22:44:17]

LGTM

[ncarter (slow), 2016-08-01 22:50:08]

The CQ bit was checked by nick@chromium.org

[ncarter (slow), 2016-08-01 22:50:08]

The patchset sent to the CQ was uploaded after l-g-t-m from afakhry@chromium.org
Link to the patchset: https://codereview.chromium.org/2146273002/#ps120001
(title: "Fix compile.")

[commit-bot: I haz the power, 2016-08-01 22:50:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 23:32:36]

Description was changed from

==========
TaskManager: when shown or activated, select the last active tab.

Introduce a method, NewTaskManagerView::SelectTaskOfActiveTab, which
allows the selection model to be updated to match the main row
of a particular WebContents. Add plumbing from the NewTaskManagerView
down to the TaskProviders to support this lookup.

Rename NewTaskManagerView::ActivateFocusedTab for consistency and accuracy
(it's basically the inverse of the new function).

Replace the ScopedVector of TaskProviders with a std::vector of unique_ptrs,
since ScopedVector is deprecated.

BUG=614551
TEST=included browser_test
==========

to

==========
TaskManager: when shown or activated, select the last active tab.

Introduce a method, NewTaskManagerView::SelectTaskOfActiveTab, which
allows the selection model to be updated to match the main row
of a particular WebContents. Add plumbing from the NewTaskManagerView
down to the TaskProviders to support this lookup.

Rename NewTaskManagerView::ActivateFocusedTab for consistency and accuracy
(it's basically the inverse of the new function).

Replace the ScopedVector of TaskProviders with a std::vector of unique_ptrs,
since ScopedVector is deprecated.

BUG=614551
TEST=included browser_test
==========

[commit-bot: I haz the power, 2016-08-01 23:32:37]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-08-01 23:42:08]

Description was changed from

==========
TaskManager: when shown or activated, select the last active tab.

Introduce a method, NewTaskManagerView::SelectTaskOfActiveTab, which
allows the selection model to be updated to match the main row
of a particular WebContents. Add plumbing from the NewTaskManagerView
down to the TaskProviders to support this lookup.

Rename NewTaskManagerView::ActivateFocusedTab for consistency and accuracy
(it's basically the inverse of the new function).

Replace the ScopedVector of TaskProviders with a std::vector of unique_ptrs,
since ScopedVector is deprecated.

BUG=614551
TEST=included browser_test
==========

to

==========
TaskManager: when shown or activated, select the last active tab.

Introduce a method, NewTaskManagerView::SelectTaskOfActiveTab, which
allows the selection model to be updated to match the main row
of a particular WebContents. Add plumbing from the NewTaskManagerView
down to the TaskProviders to support this lookup.

Rename NewTaskManagerView::ActivateFocusedTab for consistency and accuracy
(it's basically the inverse of the new function).

Replace the ScopedVector of TaskProviders with a std::vector of unique_ptrs,
since ScopedVector is deprecated.

BUG=614551
TEST=included browser_test

Committed: https://crrev.com/1824ae3ede49ac7e6cf6224d03e713fab8070c30
Cr-Commit-Position: refs/heads/master@{#409087}
==========

[commit-bot: I haz the power, 2016-08-01 23:42:10]

Patchset 7 (id:??) landed as
https://crrev.com/1824ae3ede49ac7e6cf6224d03e713fab8070c30
Cr-Commit-Position: refs/heads/master@{#409087}