Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: components/test_runner/web_frame_test_client.cc

Issue 2147633003: PlzNavigate: Eliminate test_runner bailing out of layout tests too early (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/web_frame_test_client.cc
diff --git a/components/test_runner/web_frame_test_client.cc b/components/test_runner/web_frame_test_client.cc
index d5eccbfef003146d05abff6b61fed71e42333fc5..2f40f36060d2a7cf13b7f201cc73e4cf727c6e7b 100644
--- a/components/test_runner/web_frame_test_client.cc
+++ b/components/test_runner/web_frame_test_client.cc
@@ -511,6 +511,18 @@ void WebFrameTestClient::didFinishLoad(blink::WebLocalFrame* frame) {
}
}
+void WebFrameTestClient::didNavigateWithinPage(
+ blink::WebLocalFrame* frame,
+ const blink::WebHistoryItem& history_item,
+ blink::WebHistoryCommitType commit_type,
+ bool contentInitiated) {
+ test_runner_->OnNavigationEnd();
clamy 2016/07/27 16:57:05 Based on what we discussed offline, do you still n
blundell 2016/07/29 15:02:46 Yes, it's needed: there is at least one test where
+}
+
+void WebFrameTestClient::didStartLoading(bool to_different_document) {
+ test_runner_->OnNavigationBegin();
+}
+
void WebFrameTestClient::didStopLoading() {
test_runner_->tryToClearTopLoadingFrame(
web_frame_test_proxy_base_->web_frame());

Powered by Google App Engine
This is Rietveld 408576698