Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: components/test_runner/web_frame_test_proxy.h

Issue 2147633003: PlzNavigate: Eliminate test_runner bailing out of layout tests too early (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/web_frame_test_proxy.h
diff --git a/components/test_runner/web_frame_test_proxy.h b/components/test_runner/web_frame_test_proxy.h
index 21bd773dd725caeef25de1a9d6d85af80e03bc77..fee7207ec9ebeb2ed6fd6f09714a533a8d6911d5 100644
--- a/components/test_runner/web_frame_test_proxy.h
+++ b/components/test_runner/web_frame_test_proxy.h
@@ -163,6 +163,16 @@ class WebFrameTestProxy : public Base, public WebFrameTestProxyBase {
test_client()->didFinishLoad(frame);
}
+ void didNavigateWithinPage(blink::WebLocalFrame* frame,
+ const blink::WebHistoryItem& history_item,
+ blink::WebHistoryCommitType commit_type,
+ bool content_initiated) override {
+ Base::didNavigateWithinPage(frame, history_item, commit_type,
+ content_initiated);
+ test_client()->didNavigateWithinPage(frame, history_item, commit_type,
+ content_initiated);
+ }
+
void didStopLoading() override {
Base::didStopLoading();
test_client()->didStopLoading();
@@ -263,6 +273,11 @@ class WebFrameTestProxy : public Base, public WebFrameTestProxyBase {
return Base::decidePolicyForNavigation(info);
}
+ void didStartLoading(bool to_different_document) override {
+ Base::didStartLoading(to_different_document);
+ test_client()->didStartLoading(to_different_document);
+ }
+
void willStartUsingPeerConnectionHandler(
blink::WebRTCPeerConnectionHandler* handler) override {
// RenderFrameImpl::willStartUsingPeerConnectionHandler can not be mocked.

Powered by Google App Engine
This is Rietveld 408576698