PlzNavigate: Eliminate test_runner bailing out of layout tests too early

components/test_runner/test_runner.h

Index: components/test_runner/test_runner.h
diff --git a/components/test_runner/test_runner.h b/components/test_runner/test_runner.h
index d9e1a1ca68f3e8bc5039f37644a854a61efe9bac..80a156e934bd1ddb9a8de6fe8a1dc16dbf4b8917 100644
--- a/components/test_runner/test_runner.h
+++ b/components/test_runner/test_runner.h
@@ -99,6 +99,8 @@ class TestRunner : public WebTestRunner {
   void SetFocus(blink::WebView* web_view, bool focus) override;
 
   // Methods used by WebViewTestClient and WebFrameTestClient.
+  void OnNavigationBegin() { is_navigating_ = true; }
+  void OnNavigationEnd() { is_navigating_ = false; }
   void OnAnimationScheduled(blink::WebWidget* widget);
   void OnAnimationBegun(blink::WebWidget* widget);
   std::string GetAcceptLanguages() const;
@@ -614,6 +616,12 @@ class TestRunner : public WebTestRunner {
 
   bool use_mock_theme_;
 
+  // This is true in the period between the start of a navigation and when the
+  // provisional load for that navigation is started. Note that when
+  // browser-side navigation is enabled there is an arbitrary gap between these
+  // two events.
+  bool is_navigating_;

[clamy, 2016/07/27 16:57:05]

I find the name is_navigating_ a bit misleading, considering that it covers only
the moment between we say we are loading and the moment we get the start of the
provisional load. How about will_navigate_? Also the comment should highlight
that this is for PlzNavigate, where that gap can be quite big.

[blundell, 2016/07/29 15:02:46]

Name changed. Re: commenting, is the second sentence of the existing comment not
sufficient for those purposes?

+
   std::unique_ptr<MockCredentialManagerClient> credential_manager_client_;
   std::unique_ptr<MockScreenOrientationClient> mock_screen_orientation_client_;
   std::unique_ptr<MockWebSpeechRecognizer> speech_recognizer_;