Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2147523003: Rename WaylandDisplay to WaylandConnection (Closed)

Created:
4 years, 5 months ago by joone
Modified:
4 years, 5 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename WaylandDisplay to WaylandConnection In Chrome terminology, a Display corresponds to a single physical output CRT or LCD. However, Display represents a connection to the compositor in Wayland so we need to rename WaylandDisplay to WaylandConnection in order to avoid terminology confusion. See discussion here: https://codereview.chromium.org/2042503002/#msg21 BUG=none Committed: https://crrev.com/1f909cea4097418ded818d7090b77c8abdeb440b Cr-Commit-Position: refs/heads/master@{#405941}

Patch Set 1 #

Total comments: 6

Patch Set 2 : add argument name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -483 lines) Patch
M ui/ozone/platform/wayland/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/wayland/ozone_platform_wayland.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M ui/ozone/platform/wayland/wayland.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/ozone/platform/wayland/wayland_connection.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + ui/ozone/platform/wayland/wayland_connection.cc View 4 chunks +61 lines, -60 lines 0 comments Download
A + ui/ozone/platform/wayland/wayland_connection_unittest.cc View 1 chunk +9 lines, -9 lines 0 comments Download
D ui/ozone/platform/wayland/wayland_display.h View 1 chunk +0 lines, -87 lines 0 comments Download
D ui/ozone/platform/wayland/wayland_display.cc View 1 chunk +0 lines, -215 lines 0 comments Download
D ui/ozone/platform/wayland/wayland_display_unittest.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_pointer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/wayland/wayland_surface_factory.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_surface_factory.cc View 8 chunks +17 lines, -15 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_surface_factory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/wayland/wayland_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_window.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_window.cc View 1 6 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
joone
Please review this CL.
4 years, 5 months ago (2016-07-12 21:00:24 UTC) #3
Michael Forney
Thanks. https://codereview.chromium.org/2147523003/diff/20001/ui/ozone/platform/wayland/wayland_surface_factory.h File ui/ozone/platform/wayland/wayland_surface_factory.h (right): https://codereview.chromium.org/2147523003/diff/20001/ui/ozone/platform/wayland/wayland_surface_factory.h#newcode16 ui/ozone/platform/wayland/wayland_surface_factory.h:16: explicit WaylandSurfaceFactory(WaylandConnection*); This argument should have a name. ...
4 years, 5 months ago (2016-07-12 21:06:49 UTC) #4
joone
Thanks for the review! https://codereview.chromium.org/2147523003/diff/20001/ui/ozone/platform/wayland/wayland_surface_factory.h File ui/ozone/platform/wayland/wayland_surface_factory.h (right): https://codereview.chromium.org/2147523003/diff/20001/ui/ozone/platform/wayland/wayland_surface_factory.h#newcode16 ui/ozone/platform/wayland/wayland_surface_factory.h:16: explicit WaylandSurfaceFactory(WaylandConnection*); On 2016/07/12 21:06:49, ...
4 years, 5 months ago (2016-07-13 22:35:41 UTC) #5
Michael Forney
lgtm
4 years, 5 months ago (2016-07-14 19:36:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147523003/40001
4 years, 5 months ago (2016-07-14 20:27:15 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-14 20:27:16 UTC) #10
rjkroege
lgtm
4 years, 5 months ago (2016-07-15 18:30:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147523003/40001
4 years, 5 months ago (2016-07-15 20:23:42 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/245195)
4 years, 5 months ago (2016-07-15 22:24:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147523003/40001
4 years, 5 months ago (2016-07-16 09:19:53 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-07-16 09:43:46 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-16 09:55:06 UTC) #20
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1f909cea4097418ded818d7090b77c8abdeb440b
Cr-Commit-Position: refs/heads/master@{#405941}

Powered by Google App Engine
This is Rietveld 408576698