Chromium Code Reviews Chromium Code Reviews
Issue 2147063002:
MD Settings: About page, localize remaining strings. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/resources/settings/about_page/detailed_build_info.html |
| diff --git a/chrome/browser/resources/settings/about_page/detailed_build_info.html b/chrome/browser/resources/settings/about_page/detailed_build_info.html |
| index 786831aab3d37627c2ad7723f5d1cabb02b8940a..f1f95b9df79ab3382d8f97ed4933ba81a63d5b76 100644 |
| --- a/chrome/browser/resources/settings/about_page/detailed_build_info.html |
| +++ b/chrome/browser/resources/settings/about_page/detailed_build_info.html |
| @@ -17,23 +17,20 @@ |
| </style> |
| <div class="settings-box two-line"> |
| <div class="start"> |
| - <!-- TODO(dpapad): Localize string --> |
| - <div>Platform</div> |
| + <div>$i18n{aboutPlatformLabel}</div> |
| <div class="secondary" id="osVersion">[[versionInfo_.osVersion]]</div> |
| </div> |
| </div> |
| <div class="settings-box two-line" |
| hidden$="[[!shouldShowVersion_(versionInfo_.osFirmware)]]"> |
| <div class="start"> |
| - <!-- TODO(dpapad): Localize string --> |
| - <div>Firmware</div> |
| + <div>$i18n{aboutFirmwareLabel}</div> |
| <div class="secondary" id="osFirmware">[[versionInfo_.osFirmware]]</div> |
| </div> |
| </div> |
| <div class="settings-box two-line"> |
| <div class="start"> |
| - <!-- TODO(dpapad): Localize string --> |
| - <div>Channel</div> |
| + <div>$i18n{aboutChannelLabel}</div> |
| <div class="secondary">[[currentlyOnChannelText_]]</div> |
| </div> |
| <div class="secondary-action"> |
| @@ -50,14 +47,12 @@ |
| <div class="settings-box two-line" |
| hidden$="[[!shouldShowVersion_(versionInfo_.arcVersion)]]"> |
| <div class="start"> |
| - <!-- TODO(dpapad): Localize string --> |
| - <div>ARC Version</div> |
| + <div>$i18n{aboutArcVersionLabel}</div> |
| <div class="secondary" id="arcVersion">[[versionInfo_.arcVersion]]</div> |
| </div> |
| </div> |
| <div class="settings-box two-line"> |
| <div class="start"> |
| - <!-- TODO(dpapad): Localize string --> |
| <div>Blink</div> |
|
tommycli
2016/07/13 21:54:05
Needs $i18n tag here
dpapad
2016/07/13 22:06:32
Don't see a value in localizing this. The old Opti
tommycli
2016/07/13 22:18:43
I see. Add a comment explaining "Blink should neve
dpapad
2016/07/13 22:31:13
Added comment.
|
| <div class="secondary">$i18n{aboutBlinkVersion}</div> |
| </div> |
| @@ -70,22 +65,19 @@ |
| </div> |
| <div class="settings-box two-line"> |
| <div class="start"> |
| - <!-- TODO(dpapad): Localize string --> |
| - <div>User agent</div> |
| + <div>$i18n{aboutUserAgentLabel}</div> |
| <div class="secondary">$i18n{aboutUserAgent}</div> |
| </div> |
| </div> |
| <div class="settings-box two-line"> |
| <div class="start"> |
| - <!-- TODO(dpapad): Localize string --> |
| - <div>Command line</div> |
| + <div>$i18n{aboutCommandLineLabel}</div> |
| <div class="secondary">$i18n{aboutCommandLine}</div> |
| </div> |
| </div> |
| <div class="settings-box two-line"> |
| <div class="start"> |
| - <!-- TODO(dpapad): Localize string --> |
| - <div>Build date</div> |
| + <div>$i18n{aboutBuildDateLabel}</div> |
| <div class="secondary">$i18n{aboutBuildDate}</div> |
| </div> |
| </div> |
