MD Settings: About page, localize remaining strings.

chrome/browser/resources/settings/about_page/detailed_build_info.html

 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="/about_page/about_page_browser_proxy.html">
 <link rel="import" href="/about_page/channel_switcher_dialog.html">
 <link rel="import" href="/i18n_setup.html"
 <link rel="import" href="/settings_shared_css.html">
 <link rel="import" href="chrome://resources/cr_elements/icons.html">
 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
 
 <dom-module id="settings-detailed-build-info">
   <template>
     <style include="settings-shared">
       .secondary {
         -webkit-user-select: text;
       }
     </style>
     <div class="settings-box two-line">
       <div class="start">
-        <!-- TODO(dpapad): Localize string -->
-        <div>Platform</div>
+        <div>$i18n{aboutPlatformLabel}</div>
         <div class="secondary" id="osVersion">[[versionInfo_.osVersion]]</div>
       </div>
     </div>
     <div class="settings-box two-line"
         hidden$="[[!shouldShowVersion_(versionInfo_.osFirmware)]]">
       <div class="start">
-        <!-- TODO(dpapad): Localize string -->
-        <div>Firmware</div>
+        <div>$i18n{aboutFirmwareLabel}</div>
         <div class="secondary" id="osFirmware">[[versionInfo_.osFirmware]]</div>
       </div>
     </div>
     <div class="settings-box two-line">
       <div class="start">
-        <!-- TODO(dpapad): Localize string -->
-        <div>Channel</div>
+        <div>$i18n{aboutChannelLabel}</div>
         <div class="secondary">[[currentlyOnChannelText_]]</div>
       </div>
       <div class="secondary-action">
         <paper-button on-tap="onChangeChannelTap_"
             disabled="[[!canChangeChannel_]]">
           $i18n{aboutChangeChannel}
         </paper-button>
         <iron-icon icon="cr:domain" hidden="[[canChangeChannel_]]"</iron-icon>
       </div>
       <template is="dom-if" if="[[showChannelSwitcherDialog_]]" restamp>
         <settings-channel-switcher-dialog></settings-channel-switcher-dialog>
       </template>
     </div>
     <div class="settings-box two-line"
         hidden$="[[!shouldShowVersion_(versionInfo_.arcVersion)]]">
       <div class="start">
-        <!-- TODO(dpapad): Localize string -->
-        <div>ARC Version</div>
+        <div>$i18n{aboutArcVersionLabel}</div>
         <div class="secondary" id="arcVersion">[[versionInfo_.arcVersion]]</div>
       </div>
     </div>
     <div class="settings-box two-line">
       <div class="start">
-        <!-- TODO(dpapad): Localize string -->
         <div>Blink</div>

[tommycli, 2016/07/13 21:54:05]

Needs $i18n tag here

[dpapad, 2016/07/13 22:06:32]

Don't see a value in localizing this. The old Options was seemingly localizing
this, but the comment says "should not require translation", see
https://cs.chromium.org/chromium/src/chrome/app/generated_resources.grd?q=IDS....

[tommycli, 2016/07/13 22:18:43]

I see. Add a comment explaining "Blink should never be localized"?

[dpapad, 2016/07/13 22:31:13]

Added comment.

         <div class="secondary">$i18n{aboutBlinkVersion}</div>
       </div>
     </div>
     <div class="settings-box two-line">
       <div class="start">
         <div>V8</div>
         <div class="secondary">$i18n{aboutJsEngineVersion}</div>
       </div>
     </div>
     <div class="settings-box two-line">
       <div class="start">
-        <!-- TODO(dpapad): Localize string -->
-        <div>User agent</div>
+        <div>$i18n{aboutUserAgentLabel}</div>
         <div class="secondary">$i18n{aboutUserAgent}</div>
       </div>
     </div>
     <div class="settings-box two-line">
       <div class="start">
-        <!-- TODO(dpapad): Localize string -->
-        <div>Command line</div>
+        <div>$i18n{aboutCommandLineLabel}</div>
         <div class="secondary">$i18n{aboutCommandLine}</div>
       </div>
     </div>
     <div class="settings-box two-line">
       <div class="start">
-        <!-- TODO(dpapad): Localize string -->
-        <div>Build date</div>
+        <div>$i18n{aboutBuildDateLabel}</div>
         <div class="secondary">$i18n{aboutBuildDate}</div>
       </div>
     </div>
   </template>
   <script src="detailed_build_info.js"></script>
 </dom-module>