Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: chrome/app/settings_strings.grdp

Issue 2147063002: MD Settings: About page, localize remaining strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: One more string. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/settings_strings.grdp
diff --git a/chrome/app/settings_strings.grdp b/chrome/app/settings_strings.grdp
index 3c6d00f5c14efe1db11fd5447b68e039cea02007..e4ca49402a64547a27706955c2c0e622b16fc999 100644
--- a/chrome/app/settings_strings.grdp
+++ b/chrome/app/settings_strings.grdp
@@ -3,6 +3,15 @@
<grit-part>
<!-- About Page -->
<if expr="chromeos">
+ <message name="IDS_SETTINGS_ABOUT_PAGE_DETAILED_BUILD_INFO" desc="Label describing the section that shows detailed information about the current Chrome build.">
+ Detailed build information
+ </message>
+ <message name="IDS_SETTINGS_ABOUT_PAGE_ARC_VERSION" desc="Label for ARC version">
+ ARC Version
+ </message>
+ <message name="IDS_SETTINGS_ABOUT_PAGE_CHANNEL" desc="The channel label under Detailed build info.">
+ Channel
+ </message>
<message name="IDS_SETTINGS_ABOUT_PAGE_CHECK_FOR_UPDATES" desc="The button label to check for updates and apply (download and install) if found">
Check for updates
</message>
@@ -18,6 +27,12 @@
<message name="IDS_SETTINGS_ABOUT_PAGE_CURRENT_CHANNEL" desc="The message about current channel.">
Currently on <ph name="CHANNEL_NAME">$1<ex>stable</ex></ph>
</message>
+ <message name="IDS_SETTINGS_ABOUT_PAGE_FIRMWARE" desc="Label used for Chrome OS bios firmware version.">
tommycli 2016/07/13 21:54:05 nit: Isn't it always BIOS all caps?
dpapad 2016/07/13 22:06:32 Done (these descriptions were simply copied from o
+ Firmware
+ </message>
+ <message name="IDS_SETTINGS_ABOUT_PAGE_PLATFORM" desc="Label for Platform">
tommycli 2016/07/13 21:54:05 Maybe expand desc. to "Label for Platform (i.e. Li
dpapad 2016/07/13 22:06:32 It does not mean linux/mac/windows. This code is o
tommycli 2016/07/13 22:18:43 Oh I see. Kind of hard to describe I guess. At lea
+ Platform
+ </message>
<message name="IDS_SETTINGS_ABOUT_PAGE_RELAUNCH" desc="The label for the relaunch button that relaunches the browser once update is complete">
Restart
</message>

Powered by Google App Engine
This is Rietveld 408576698