Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2147063002: MD Settings: About page, localize remaining strings. (Closed)

Created:
4 years, 5 months ago by dpapad
Modified:
4 years, 5 months ago
Reviewers:
tommycli
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: About page, localize remaining strings. BUG=627929 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8379f51dc3a4b447bbce3f479aece354214914bc Cr-Commit-Position: refs/heads/master@{#405354}

Patch Set 1 : One more string. #

Total comments: 9

Patch Set 2 : Nit. #

Patch Set 3 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -20 lines) Patch
M chrome/app/settings_strings.grdp View 1 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.html View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/about_page/detailed_build_info.html View 1 2 3 chunks +8 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-13 21:13:51 UTC) #5
dpapad
4 years, 5 months ago (2016-07-13 21:17:46 UTC) #7
tommycli
LGTM sans below issues, and assuming you've tested this manually to make sure all the ...
4 years, 5 months ago (2016-07-13 21:54:06 UTC) #8
dpapad
https://codereview.chromium.org/2147063002/diff/20001/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2147063002/diff/20001/chrome/app/settings_strings.grdp#newcode30 chrome/app/settings_strings.grdp:30: <message name="IDS_SETTINGS_ABOUT_PAGE_FIRMWARE" desc="Label used for Chrome OS bios firmware ...
4 years, 5 months ago (2016-07-13 22:06:32 UTC) #9
tommycli
okay thanks https://codereview.chromium.org/2147063002/diff/20001/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2147063002/diff/20001/chrome/app/settings_strings.grdp#newcode33 chrome/app/settings_strings.grdp:33: <message name="IDS_SETTINGS_ABOUT_PAGE_PLATFORM" desc="Label for Platform"> On 2016/07/13 ...
4 years, 5 months ago (2016-07-13 22:18:43 UTC) #10
dpapad
Thanks! https://codereview.chromium.org/2147063002/diff/20001/chrome/browser/resources/settings/about_page/detailed_build_info.html File chrome/browser/resources/settings/about_page/detailed_build_info.html (right): https://codereview.chromium.org/2147063002/diff/20001/chrome/browser/resources/settings/about_page/detailed_build_info.html#newcode56 chrome/browser/resources/settings/about_page/detailed_build_info.html:56: <div>Blink</div> > I see. Add a comment explaining ...
4 years, 5 months ago (2016-07-13 22:31:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147063002/60001
4 years, 5 months ago (2016-07-13 22:36:10 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 5 months ago (2016-07-13 23:59:13 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 23:59:32 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 00:01:04 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8379f51dc3a4b447bbce3f479aece354214914bc
Cr-Commit-Position: refs/heads/master@{#405354}

Powered by Google App Engine
This is Rietveld 408576698