Issue 2146993002: Remove default params in CPDF_VariableText.

Issue 2146993002: Remove default params in CPDF_VariableText. (Closed)

Created:
4 years, 5 months ago by dsinclair

Modified:
4 years, 5 months ago

Reviewers:
Lei Zhang, Wei Li

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@ifx_cleanup_3

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Remove default params in CPDF_VariableText. This Cl cleans up the default params and any supporting code if necessary. Committed: https://pdfium.googlesource.com/pdfium/+/74a30b76a0a50fc92cb567fa2a9e3500f04c0883

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -53 lines)			Patch
M	core/fpdfdoc/cpdf_variabletext.cpp	View	1	7 chunks	+11 lines, -22 lines	0 comments	Download
M	core/fpdfdoc/ctypeset.cpp	View	1 2 3	1 chunk	+2 lines, -4 lines	0 comments	Download
M	core/fpdfdoc/include/cpdf_variabletext.h	View	1	4 chunks	+17 lines, -27 lines	0 comments	Download

Depends on Patchset:

Dependent Patchsets:

Total messages: 9 (3 generated)

dsinclair

On 2016/07/13 19:24:24, Lei Zhang (Slow Thursday) wrote: > Bots look red. Fixed (the gyp ...

4 years, 5 months ago (2016-07-14 15:30:43 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146993002/60001

4 years, 5 months ago (2016-07-18 17:06:22 UTC) #7

commit-bot: I haz the power

4 years, 5 months ago (2016-07-18 17:18:59 UTC) #9

Message was sent while issue was closed.

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/74a30b76a0a50fc92cb567fa2a9e3500f04c...