Removing default params from CFX_Edit.

Removing default params from CFX_Edit.

This CL removes all of the default params from CFX_Edit. They are either
moved to the callsite or removed completely if unused.

Committed: https://pdfium.googlesource.com/pdfium/+/efd5a99f98a263da9de52059681ff6ed27b2567c

[dsinclair, 2016-07-13 18:39:42]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-07-13 18:39:43]

PTAL.

[Lei Zhang, 2016-07-13 19:35:15]

https://codereview.chromium.org/2152473002/diff/40001/fpdfsdk/fxedit/fxet_edi...
File fpdfsdk/fxedit/fxet_edit.cpp (left):

https://codereview.chromium.org/2152473002/diff/40001/fpdfsdk/fxedit/fxet_edi...
fpdfsdk/fxedit/fxet_edit.cpp:804: m_pEdit->InsertText(m_swText.c_str(),
m_nCharset, &m_SecProps, &m_WordProps,
Can you help convince me this is safe to remove?

[dsinclair, 2016-07-14 14:16:53]

https://codereview.chromium.org/2152473002/diff/40001/fpdfsdk/fxedit/fxet_edi...
File fpdfsdk/fxedit/fxet_edit.cpp (left):

https://codereview.chromium.org/2152473002/diff/40001/fpdfsdk/fxedit/fxet_edi...
fpdfsdk/fxedit/fxet_edit.cpp:804: m_pEdit->InsertText(m_swText.c_str(),
m_nCharset, &m_SecProps, &m_WordProps,
On 2016/07/13 19:35:15, Lei Zhang (Slow Thursday) wrote:
> Can you help convince me this is safe to remove?


CFXEU_InsertText is created in CFX_Edit::InsertText and passed pSecProps and
pWordProps from the InsertText call. So, if those are always null, these are
always null and can be removed.

InsertText() is called on:
  * 772 nullptr, nullptr
  * Here, which passed values
  * 1799 with passed through values from InsertText override.

The default values for those pointers are both nullptr in the header. They are
never set in any other caller. So, they have to be null.

[Lei Zhang, 2016-07-18 16:45:14]

lgtm

[dsinclair, 2016-07-18 16:51:19]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-07-18 16:51:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 17:04:12]

Description was changed from

==========
Removing default params from CFX_Edit.

This CL removes all of the default params from CFX_Edit. They are either
moved to the callsite or removed completely if unused.
==========

to

==========
Removing default params from CFX_Edit.

This CL removes all of the default params from CFX_Edit. They are either
moved to the callsite or removed completely if unused.

Committed:
https://pdfium.googlesource.com/pdfium/+/efd5a99f98a263da9de52059681ff6ed27b2...
==========

[commit-bot: I haz the power, 2016-07-18 17:04:13]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/efd5a99f98a263da9de52059681ff6ed27b2...