core/fpdfdoc/ctypeset.cpp - Issue 2146993002: Remove default params in CPDF_VariableText.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/ctypeset.cpp

Issue 2146993002: Remove default params in CPDF_VariableText. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@ifx_cleanup_3

Patch Set: Fix calls to GetFont{Ascent|Descent} Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/ctypeset.cpp

diff --git a/core/fpdfdoc/ctypeset.cpp b/core/fpdfdoc/ctypeset.cpp

index 8c85e7992291cd59ef3dc9bcf164fbfdc87e5862..57d3733dc3f65749f482ba3f46f52bc1218f523a 100644

--- a/core/fpdfdoc/ctypeset.cpp

+++ b/core/fpdfdoc/ctypeset.cpp

@@ -300,10 +300,8 @@ void CTypeset::SplitLines(FX_BOOL bTypeset, FX_FLOAT fFontSize) {

}

if (pWord) {

if (bTypeset) {

- fLineAscent =

- std::max(fLineAscent, m_pVT->GetWordAscent(*pWord, TRUE));

- fLineDescent =

- std::min(fLineDescent, m_pVT->GetWordDescent(*pWord, TRUE));

+ fLineAscent = std::max(fLineAscent, m_pVT->GetWordAscent(*pWord));

+ fLineDescent = std::min(fLineDescent, m_pVT->GetWordDescent(*pWord));

fWordWidth = m_pVT->GetWordWidth(*pWord);

} else {

fLineAscent =

« no previous file with comments | « core/fpdfdoc/cpdf_variabletext.cpp ('k') | core/fpdfdoc/include/cpdf_variabletext.h » ('j') | no next file with comments »