Fix CopyTexImage2D when using unsized internal formats

Fix CopyTexImage2D when using unsized internal formats

CopyTexImage2D accepts unsized internal formats, but the code didn't properly
handle all possible cases, resulting in us storing 0 as format/type in the level
info. This can be problematic later on, e.g. triggering asserts if the texture
is used as a FBO to copy from.
This CL makes sure we're at the very least consistent, but doesn't fully
implement the spec which has specific rules to pick an effective internal format
depending on the framebuffer format.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fb68ed91e9fa7851dfc73b29cf0fff2d0cd8d8e6
Cr-Commit-Position: refs/heads/master@{#405511}

[piman, 2016-07-14 00:59:12]

Description was changed from

==========
Fix CopyTexImage2D when using unsized internal formats

CopyTexImage2D accepts unsized internal formats, but the code didn't properly
handle all possible cases, resulting in us storing 0 as format/type in the level
info. This can be problematic later on, e.g. triggering asserts if the texture
is used as a FBO to copy from.
This CL makes sure we're at the very least consistent, but doesn't fully
implement the spec which has specific rules to pick an effective internal format
depending on the framebuffer format.

BUG=None
==========

to

==========
Fix CopyTexImage2D when using unsized internal formats

CopyTexImage2D accepts unsized internal formats, but the code didn't properly
handle all possible cases, resulting in us storing 0 as format/type in the level
info. This can be problematic later on, e.g. triggering asserts if the texture
is used as a FBO to copy from.
This CL makes sure we're at the very least consistent, but doesn't fully
implement the spec which has specific rules to pick an effective internal format
depending on the framebuffer format.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-07-14 00:59:17]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 01:00:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-07-14 01:00:18]

piman@chromium.org changed reviewers:
+ zmo@chromium.org

[commit-bot: I haz the power, 2016-07-14 02:23:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 02:23:55]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-07-14 17:06:57]

lgtm

[piman, 2016-07-14 17:18:24]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-07-14 17:18:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 17:18:52]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-14 17:23:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-14 17:23:51]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 17:26:27]

Description was changed from

==========
Fix CopyTexImage2D when using unsized internal formats

CopyTexImage2D accepts unsized internal formats, but the code didn't properly
handle all possible cases, resulting in us storing 0 as format/type in the level
info. This can be problematic later on, e.g. triggering asserts if the texture
is used as a FBO to copy from.
This CL makes sure we're at the very least consistent, but doesn't fully
implement the spec which has specific rules to pick an effective internal format
depending on the framebuffer format.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix CopyTexImage2D when using unsized internal formats

CopyTexImage2D accepts unsized internal formats, but the code didn't properly
handle all possible cases, resulting in us storing 0 as format/type in the level
info. This can be problematic later on, e.g. triggering asserts if the texture
is used as a FBO to copy from.
This CL makes sure we're at the very least consistent, but doesn't fully
implement the spec which has specific rules to pick an effective internal format
depending on the framebuffer format.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fb68ed91e9fa7851dfc73b29cf0fff2d0cd8d8e6
Cr-Commit-Position: refs/heads/master@{#405511}
==========

[commit-bot: I haz the power, 2016-07-14 17:26:29]

Patchset 1 (id:??) landed as
https://crrev.com/fb68ed91e9fa7851dfc73b29cf0fff2d0cd8d8e6
Cr-Commit-Position: refs/heads/master@{#405511}