Fix CopyTexImage2D when using unsized internal formats

gpu/command_buffer/service/gles2_cmd_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <stdio.h>
@@ skipping 12646 matching lines @@
   }
 
   GLenum read_format = GetBoundReadFrameBufferInternalFormat();
   GLenum read_type = GetBoundReadFrameBufferTextureType();
   if (!ValidateCopyTexFormat(func_name, internal_format,
                              read_format, read_type)) {
     return;
   }
 
   uint32_t pixels_size = 0;
-  GLenum format = TextureManager::ExtractFormatFromStorageFormat(
-      internal_format);
+  // TODO(piman): OpenGL ES 3.0.4 Section 3.8.5 specifies how to pick an
+  // effective internal format if internal_format is unsized, which is a fairly
+  // involved logic. For now, just make sure we pick something valid.
+  GLenum format =
+      TextureManager::ExtractFormatFromStorageFormat(internal_format);
   GLenum type = TextureManager::ExtractTypeFromStorageFormat(internal_format);
+  if (!format || !type) {
+    LOCAL_SET_GL_ERROR(
+        GL_INVALID_OPERATION,
+        func_name, "Invalid unsized internal format.");
+    return;
+  }
+
+  DCHECK(texture_manager()->ValidateTextureParameters(
+      GetErrorState(), func_name, true, format, type, internal_format, level));
+
   // Only target image size is validated here.
   if (!GLES2Util::ComputeImageDataSizes(
       width, height, 1, format, type,
       state_.unpack_alignment, &pixels_size, NULL, NULL)) {
     LOCAL_SET_GL_ERROR(GL_OUT_OF_MEMORY, func_name, "dimensions too large");
     return;
   }
 
   if (!EnsureGPUMemoryAvailable(pixels_size)) {
     LOCAL_SET_GL_ERROR(GL_OUT_OF_MEMORY, func_name, "out of memory");
@@ skipping 4668 matching lines @@
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "base/macros.h"
 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu