Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2146593002:
WebGL2: Update Windows test expectations. (Closed)
|
Created:
4 years, 5 months ago by Jamie Madill Modified:
4 years, 4 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWebGL2: Update Windows test expectations.
Several failures have tracking bugs or were mis-classified.
BUG=483282, 627531, 624506, 626068
BUG=angleproject:1246, angleproject:1268
R=kbr@chromium.org,zmo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/cee3156deaeeb23a88258a4823d6eb1da4670932
Cr-Commit-Position: refs/heads/master@{#406013}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Undo changes to fbo/invalidate/whole #Patch Set 3 : rebase #Patch Set 4 : Change xfb to Fail always #Messages
Total messages: 32 (14 generated)
Description was changed from ========== WebGL2: Update Windows test expectations. Several failures have tracking bugs or were mis-classified. BUG=483282,627531,624506,626068 BUG=angleproject:1246,angleproject:1268 R=kbr@chromium.org,zmo@chromium.org ========== to ========== WebGL2: Update Windows test expectations. Several failures have tracking bugs or were mis-classified. BUG=483282,627531,624506,626068 BUG=angleproject:1246,angleproject:1268 R=kbr@chromium.org,zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
PTAL
The CQ bit was checked by jmadill@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2146593002/diff/1/content/test/gpu/gpu_tests/... File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2146593002/diff/1/content/test/gpu/gpu_tests/... content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:33: self.Fail('deqp/functional/gles3/fboinvalidate/whole.html', bug=624506) This is passing on Mac.
lgtm with Mo's comment addressed.
On 2016/07/12 17:52:01, Zhenyao Mo wrote: > https://codereview.chromium.org/2146593002/diff/1/content/test/gpu/gpu_tests/... > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): > > https://codereview.chromium.org/2146593002/diff/1/content/test/gpu/gpu_tests/... > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:33: > self.Fail('deqp/functional/gles3/fboinvalidate/whole.html', bug=624506) > This is passing on Mac. Undid this part.
The CQ bit was checked by jmadill@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2146593002/#ps20001 (title: "Undo changes to fbo/invalidate/whole")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Seems to need a rebase.
The CQ bit was checked by jmadill@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2146593002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.chromium.linux
tryserver.chromium.mac
tryserver.chromium.win
For more details, see http://crbug.com/617627.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by jmadill@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2146593002/#ps60001 (title: "Change xfb to Fail always")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.chromium.linux
tryserver.chromium.mac
tryserver.chromium.win
For more details, see http://crbug.com/617627.
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== WebGL2: Update Windows test expectations. Several failures have tracking bugs or were mis-classified. BUG=483282,627531,624506,626068 BUG=angleproject:1246,angleproject:1268 R=kbr@chromium.org,zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== WebGL2: Update Windows test expectations. Several failures have tracking bugs or were mis-classified. BUG=483282,627531,624506,626068 BUG=angleproject:1246,angleproject:1268 R=kbr@chromium.org,zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/cee3156deaeeb23a88258a4823d6eb1da4670932 Cr-Commit-Position: refs/heads/master@{#406013} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/cee3156deaeeb23a88258a4823d6eb1da4670932 Cr-Commit-Position: refs/heads/master@{#406013} |
