Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2146413002:
Add SkRasterPipeline blitter. (Closed)
DescriptionAdd SkRasterPipeline blitter.
This is now pixel-exact with the existing sRGB SW impl as far as I've tested.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot
Committed: https://skia.googlesource.com/skia/+/3011e337693a9786f62d8de9ac4b239ad6dbdaca
Committed: https://skia.googlesource.com/skia/+/9a5c47f4effba3b48a9a8c7c144b72b532d06efe
Patch Set 1 #Patch Set 2 : Looking real. #Patch Set 3 : blitH seems plausible #Patch Set 4 : first pass on blitAntiH #Patch Set 5 : first blitMask pass #Patch Set 6 : sigh, use constants... it is bgr565 #Patch Set 7 : tweaks and comments #Patch Set 8 : rebase #Patch Set 9 : force opaque when using lcd coverage #Patch Set 10 : handle paint color conversion ourselves #Patch Set 11 : moot #Patch Set 12 : misleading comment #
Total comments: 7
Patch Set 13 : class, SkCoreBlitters #Patch Set 14 : Rebase. Diffs are now just lcd text. #Patch Set 15 : Work around contains(x,y) asserts in mask.getAddr*(). We add it back... #Patch Set 16 : restore clamps #Patch Set 17 : undo clamp... no double clamp #Patch Set 18 : Fix bgra. Now pixel perfect. #Patch Set 19 : Do not leak the blitter. #
Messages
Total messages: 51 (35 generated)
Description was changed from ========== Add SkRasterPipeline blitter. BUG=skia: ========== to ========== Add SkRasterPipeline blitter. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 ==========
Description was changed from ========== Add SkRasterPipeline blitter. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 ========== to ========== Add SkRasterPipeline blitter. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot ==========
Description was changed from ========== Add SkRasterPipeline blitter. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot ========== to ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot ==========
mtklein@chromium.org changed reviewers: + reed@google.com
love it lgtm https://codereview.chromium.org/2146413002/diff/220001/src/core/SkRasterPipel... File src/core/SkRasterPipelineBlitter.cpp (right): https://codereview.chromium.org/2146413002/diff/220001/src/core/SkRasterPipel... src/core/SkRasterPipelineBlitter.cpp:18: struct SkRasterPipelineBlitter : public SkBlitter { class? https://codereview.chromium.org/2146413002/diff/220001/src/core/SkRasterPipel... src/core/SkRasterPipelineBlitter.cpp:263: if (!paint.getShader()) { didn't we already check on line 238? https://codereview.chromium.org/2146413002/diff/220001/src/core/SkRasterPipel... File src/core/SkRasterPipelineBlitter.h (right): https://codereview.chromium.org/2146413002/diff/220001/src/core/SkRasterPipel... src/core/SkRasterPipelineBlitter.h:15: std::unique_ptr<SkBlitter> SkCreateRasterPipelineBlitter(const SkPixmap&, const SkPaint&); Could just add this declaration to SkCoreBlitters.h
mtklein@google.com changed reviewers: + mtklein@google.com
https://codereview.chromium.org/2146413002/diff/220001/src/core/SkRasterPipel... File src/core/SkRasterPipelineBlitter.cpp (right): https://codereview.chromium.org/2146413002/diff/220001/src/core/SkRasterPipel... src/core/SkRasterPipelineBlitter.cpp:18: struct SkRasterPipelineBlitter : public SkBlitter { On 2016/07/20 13:09:59, reed1 wrote: > class? Done. https://codereview.chromium.org/2146413002/diff/220001/src/core/SkRasterPipel... src/core/SkRasterPipelineBlitter.cpp:263: if (!paint.getShader()) { On 2016/07/20 13:09:59, reed1 wrote: > didn't we already check on line 238? Yep. This check will stay long-term, the one on 238 is temporary until I get shaders an appendStages(). https://codereview.chromium.org/2146413002/diff/220001/src/core/SkRasterPipel... File src/core/SkRasterPipelineBlitter.h (right): https://codereview.chromium.org/2146413002/diff/220001/src/core/SkRasterPipel... src/core/SkRasterPipelineBlitter.h:15: std::unique_ptr<SkBlitter> SkCreateRasterPipelineBlitter(const SkPixmap&, const SkPaint&); On 2016/07/20 13:09:59, reed1 wrote: > Could just add this declaration to SkCoreBlitters.h Done.
Description was changed from ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot ========== to ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot COMMIT=false Several prelude bug fix CLs are still pending. Want to minimize the incidental diff from this CL before landing. ==========
lgtm https://codereview.chromium.org/2146413002/diff/220001/src/core/SkRasterPipel... File src/core/SkRasterPipelineBlitter.cpp (right): https://codereview.chromium.org/2146413002/diff/220001/src/core/SkRasterPipel... src/core/SkRasterPipelineBlitter.cpp:263: if (!paint.getShader()) { On 2016/07/20 13:29:03, mtklein wrote: > On 2016/07/20 13:09:59, reed1 wrote: > > didn't we already check on line 238? > > Yep. This check will stay long-term, the one on 238 is temporary until I get > shaders an appendStages(). That's what I figured. sgtm
Description was changed from ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot COMMIT=false Several prelude bug fix CLs are still pending. Want to minimize the incidental diff from this CL before landing. ========== to ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot ==========
The CQ bit was checked by mtklein@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com Link to the patchset: https://codereview.chromium.org/2146413002/#ps260001 (title: "Rebase. Diffs are now just lcd text.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by mtklein@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com Link to the patchset: https://codereview.chromium.org/2146413002/#ps280001 (title: "Work around contains(x,y) asserts in mask.getAddr*(). We add it back...")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by mtklein@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com Link to the patchset: https://codereview.chromium.org/2146413002/#ps300001 (title: "restore clamps")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
Description was changed from ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot ========== to ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot r[2]: 1.00093, want [-1e-05,1.00001] ../../src/core/SkXfermode.cpp:943: fatal error: "assert(r.fVec[i] >= min && r.fVec[i] <= max)" Caught signal 6 [Aborted], was running: srgb gm hairmodes ==========
Description was changed from ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot r[2]: 1.00093, want [-1e-05,1.00001] ../../src/core/SkXfermode.cpp:943: fatal error: "assert(r.fVec[i] >= min && r.fVec[i] <= max)" Caught signal 6 [Aborted], was running: srgb gm hairmodes ========== to ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot r[2]: 1.00093, want [-1e-05,1.00001] ../../src/core/SkXfermode.cpp:943: fatal error: "assert(r.fVec[i] >= min && r.fVec[i] <= max)" Caught signal 6 [Aborted], was running: srgb gm hairmodes Only triggering with DstOver, DstATop. ==========
Description was changed from ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot r[2]: 1.00093, want [-1e-05,1.00001] ../../src/core/SkXfermode.cpp:943: fatal error: "assert(r.fVec[i] >= min && r.fVec[i] <= max)" Caught signal 6 [Aborted], was running: srgb gm hairmodes Only triggering with DstOver, DstATop. ========== to ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot r[2]: 1.00093, want [-1e-05,1.00001] ../../src/core/SkXfermode.cpp:943: fatal error: "assert(r.fVec[i] >= min && r.fVec[i] <= max)" Caught signal 6 [Aborted], was running: srgb gm hairmodes Only triggering with DstOver, DstATop. sRGB encoded color component: 188 == 0.502886 linear encoded alpha component: 128 == 0.501961 sRGB 187 == 0.496933 ==========
Description was changed from ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot r[2]: 1.00093, want [-1e-05,1.00001] ../../src/core/SkXfermode.cpp:943: fatal error: "assert(r.fVec[i] >= min && r.fVec[i] <= max)" Caught signal 6 [Aborted], was running: srgb gm hairmodes Only triggering with DstOver, DstATop. sRGB encoded color component: 188 == 0.502886 linear encoded alpha component: 128 == 0.501961 sRGB 187 == 0.496933 ========== to ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot r[2]: 1.00093, want [-1e-05,1.00001] ../../src/core/SkXfermode.cpp:943: fatal error: "assert(r.fVec[i] >= min && r.fVec[i] <= max)" Caught signal 6 [Aborted], was running: srgb gm hairmodes Only triggering with DstOver, DstATop. Explanation: sRGB encoded color component: 188 == 0.502886 linear encoded alpha component: 128 == 0.501961 sRGB 187 == 0.496933 Must have been properly < alpha when in original floats, then quantized to a non-premul value... ==========
Description was changed from ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot r[2]: 1.00093, want [-1e-05,1.00001] ../../src/core/SkXfermode.cpp:943: fatal error: "assert(r.fVec[i] >= min && r.fVec[i] <= max)" Caught signal 6 [Aborted], was running: srgb gm hairmodes Only triggering with DstOver, DstATop. Explanation: sRGB encoded color component: 188 == 0.502886 linear encoded alpha component: 128 == 0.501961 sRGB 187 == 0.496933 Must have been properly < alpha when in original floats, then quantized to a non-premul value... ========== to ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot r[2]: 1.00093, want [-1e-05,1.00001] ../../src/core/SkXfermode.cpp:943: fatal error: "assert(r.fVec[i] >= min && r.fVec[i] <= max)" Caught signal 6 [Aborted], was running: srgb gm hairmodes Only triggering with DstOver, DstATop. Explanation: sRGB encoded color component: 188 == 0.502886 linear encoded alpha component: 128 == 0.501961 sRGB 187 == 0.496933 Must have been properly <= alpha when in original floats, then quantized to a non-premul value... ==========
Description was changed from ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot r[2]: 1.00093, want [-1e-05,1.00001] ../../src/core/SkXfermode.cpp:943: fatal error: "assert(r.fVec[i] >= min && r.fVec[i] <= max)" Caught signal 6 [Aborted], was running: srgb gm hairmodes Only triggering with DstOver, DstATop. Explanation: sRGB encoded color component: 188 == 0.502886 linear encoded alpha component: 128 == 0.501961 sRGB 187 == 0.496933 Must have been properly <= alpha when in original floats, then quantized to a non-premul value... ========== to ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot r[2]: 1.00093, want [-1e-05,1.00001] ../../src/core/SkXfermode.cpp:943: fatal error: "assert(r.fVec[i] >= min && r.fVec[i] <= max)" Caught signal 6 [Aborted], was running: srgb gm hairmodes Only triggering with DstOver, DstATop. Explanation: sRGB encoded color component: 188 == 0.502886 linear encoded alpha component: 128 == 0.501961 sRGB 187 == 0.496933 Must have been properly <= alpha when in original floats, then quantized to a non-premul value... 0 0 1 1 OP 0 0 0.502886 0.501961 -> 0 0 1.00093 1 ==========
Description was changed from ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot r[2]: 1.00093, want [-1e-05,1.00001] ../../src/core/SkXfermode.cpp:943: fatal error: "assert(r.fVec[i] >= min && r.fVec[i] <= max)" Caught signal 6 [Aborted], was running: srgb gm hairmodes Only triggering with DstOver, DstATop. Explanation: sRGB encoded color component: 188 == 0.502886 linear encoded alpha component: 128 == 0.501961 sRGB 187 == 0.496933 Must have been properly <= alpha when in original floats, then quantized to a non-premul value... 0 0 1 1 OP 0 0 0.502886 0.501961 -> 0 0 1.00093 1 ========== to ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot ==========
Description was changed from ========== Add SkRasterPipeline blitter. I'd like to convert everything over to correct sRGB<->linear before landing or timing this. This fixes some bugs (especially in LCD text rendering) and appears to introduce a few, but I think fixes more than it breaks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot ========== to ========== Add SkRasterPipeline blitter. This is now pixel-exact with the existing sRGB SW impl as far as I've tested. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot ==========
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mtklein@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com Link to the patchset: https://codereview.chromium.org/2146413002/#ps340001 (title: "Fix bgra. Now pixel perfect.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add SkRasterPipeline blitter. This is now pixel-exact with the existing sRGB SW impl as far as I've tested. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot ========== to ========== Add SkRasterPipeline blitter. This is now pixel-exact with the existing sRGB SW impl as far as I've tested. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/3011e337693a9786f62d8de9ac4b239ad6dbdaca ==========
Message was sent while issue was closed.
Committed patchset #18 (id:340001) as https://skia.googlesource.com/skia/+/3011e337693a9786f62d8de9ac4b239ad6dbdaca
Message was sent while issue was closed.
A revert of this CL (patchset #18 id:340001) has been created in https://codereview.chromium.org/2178523002/ by mtklein@google.com. The reason for reverting is: Leaking the blitter https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX....
Message was sent while issue was closed.
Description was changed from ========== Add SkRasterPipeline blitter. This is now pixel-exact with the existing sRGB SW impl as far as I've tested. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/3011e337693a9786f62d8de9ac4b239ad6dbdaca ========== to ========== Add SkRasterPipeline blitter. This is now pixel-exact with the existing sRGB SW impl as far as I've tested. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot Committed: https://skia.googlesource.com/skia/+/3011e337693a9786f62d8de9ac4b239ad6dbdaca ==========
The CQ bit was checked by mtklein@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com Link to the patchset: https://codereview.chromium.org/2146413002/#ps360001 (title: "Do not leak the blitter.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add SkRasterPipeline blitter. This is now pixel-exact with the existing sRGB SW impl as far as I've tested. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot Committed: https://skia.googlesource.com/skia/+/3011e337693a9786f62d8de9ac4b239ad6dbdaca ========== to ========== Add SkRasterPipeline blitter. This is now pixel-exact with the existing sRGB SW impl as far as I've tested. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146413002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot Committed: https://skia.googlesource.com/skia/+/3011e337693a9786f62d8de9ac4b239ad6dbdaca Committed: https://skia.googlesource.com/skia/+/9a5c47f4effba3b48a9a8c7c144b72b532d06efe ==========
Message was sent while issue was closed.
Committed patchset #19 (id:360001) as https://skia.googlesource.com/skia/+/9a5c47f4effba3b48a9a8c7c144b72b532d06efe |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
