Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2146343002: Revert of Remove DOMWindowProperty::willDetachGlobalObjectFromFrame

Created:
4 years, 5 months ago by haraken
Modified:
4 years, 5 months ago
Reviewers:
dcheng
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, tzik, mlamouri+watch-blink_chromium.org, sof, eae+blinkwatch, nhiroki, blink-reviews-dom_chromium.org, dglazkov+blink, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, mvanouwerkerk+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove DOMWindowProperty::willDetachGlobalObjectFromFrame (patchset #4 id:60001 of https://codereview.chromium.org/2138003002/ ) Reason for revert: This CL caused flaky failures on http/tests/serviceworker. Original issue's description: > Remove DOMWindowProperty::willDetachGlobalObjectFromFrame > > DOMWindowProperty::willDetachGlobalObjectFromFrame is dispatched > at the same timing as ContextLifecycleObserver::contextDestroyed > (via Document::detach). Hence this CL replaces DOMWindowProperty::willDetachGlobalObjectFromFrame > with ContextLifecycleObserver::contextDestroyed. > > BUG=610176 > > Committed: https://crrev.com/f18ffebd279ad21196d988f763313e4a460db316 > Cr-Commit-Position: refs/heads/master@{#404961} TBR=dcheng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=610176

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -51 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindowProperty.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindowProperty.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp View 5 chunks +19 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.h View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/vibration/NavigatorVibration.h View 5 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp View 5 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/vibration/testing/InternalsVibration.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
haraken
Created Revert of Remove DOMWindowProperty::willDetachGlobalObjectFromFrame
4 years, 5 months ago (2016-07-14 08:28:43 UTC) #2
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 08:29:08 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698