third_party/WebKit/Source/core/dom/Document.cpp - Issue 2146343002: Revert of Remove DOMWindowProperty::willDetachGlobalObjectFromFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2146343002: Revert of Remove DOMWindowProperty::willDetachGlobalObjectFromFrame Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index 9996774c8116fc643794a8031440c71cda0db44d..02cf58affbc36372e98739234da941ad7188d69d 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -2144,6 +2144,8 @@

ScriptForbiddenScope forbidScript;

view()->dispose();

m_markers->prepareForDestruction();

+ if (LocalDOMWindow* window = this->domWindow())

+ window->willDetachDocumentFromFrame();

m_lifecycle.advanceTo(DocumentLifecycle::Stopping);

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/DOMWindowProperty.h » ('j') | no next file with comments »