Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: ash/common/wm/overview/window_selector_item.cc

Issue 2146323004: [ash-md] Improves smoothness with many windows in overview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [ash-md] Improves smoothness with many windows in overview (added flags) Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/wm/overview/window_selector_item.h ('k') | ash/frame/custom_frame_view_ash.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/wm/overview/window_selector_item.cc
diff --git a/ash/common/wm/overview/window_selector_item.cc b/ash/common/wm/overview/window_selector_item.cc
index d2e842913d188620eb2993d5541ad6fa997414e9..9f5f21c8e8623136df00b9df0aca7ab54bd54f70 100644
--- a/ash/common/wm/overview/window_selector_item.cc
+++ b/ash/common/wm/overview/window_selector_item.cc
@@ -106,7 +106,7 @@ static const float kPreCloseScale = 0.02f;
// Calculates the |window| bounds after being transformed to the selector's
// space. The returned Rect is in virtual screen coordinates.
-gfx::Rect GetTransformedBounds(WmWindow* window) {
+gfx::Rect GetTransformedBounds(WmWindow* window, bool hide_header) {
gfx::RectF bounds(
window->GetRootWindow()->ConvertRectToScreen(window->GetTargetBounds()));
gfx::Transform new_transform = TransformAboutPivot(
@@ -116,7 +116,7 @@ gfx::Rect GetTransformedBounds(WmWindow* window) {
// With Material Design the preview title is shown above the preview window.
// Hide the window header for apps or browser windows with no tabs (web apps)
// to avoid showing both the window header and the preview title.
- if (ash::MaterialDesignController::IsOverviewMaterial()) {
+ if (ash::MaterialDesignController::IsOverviewMaterial() && hide_header) {
gfx::RectF header_bounds(bounds);
header_bounds.set_height(
window->GetIntProperty(WmWindowProperty::TOP_VIEW_INSET));
@@ -215,6 +215,9 @@ class RoundedContainerView : public views::View {
} // namespace
+bool WindowSelectorItem::use_mask_ = false;
+bool WindowSelectorItem::use_shape_ = false;
+
WindowSelectorItem::OverviewLabelButton::OverviewLabelButton(
views::ButtonListener* listener,
const base::string16& text)
@@ -454,9 +457,12 @@ void WindowSelectorItem::OnWindowTitleChanged(WmWindow* window) {
float WindowSelectorItem::GetItemScale(const gfx::Size& size) {
gfx::Size inset_size(size.width(), size.height() - 2 * kWindowMarginMD);
+ const int header_inset =
+ hide_header()
+ ? GetWindow()->GetIntProperty(WmWindowProperty::TOP_VIEW_INSET)
+ : 0;
return ScopedTransformOverviewWindow::GetItemScale(
- GetWindow()->GetTargetBounds().size(), inset_size,
- GetWindow()->GetIntProperty(WmWindowProperty::TOP_VIEW_INSET),
+ GetWindow()->GetTargetBounds().size(), inset_size, header_inset,
close_button_->GetPreferredSize().height());
}
@@ -473,8 +479,10 @@ void WindowSelectorItem::SetItemBounds(const gfx::Rect& target_bounds,
int top_view_inset = 0;
int title_height = 0;
if (ash::MaterialDesignController::IsOverviewMaterial()) {
- top_view_inset =
- GetWindow()->GetIntProperty(WmWindowProperty::TOP_VIEW_INSET);
+ if (hide_header()) {
+ top_view_inset =
+ GetWindow()->GetIntProperty(WmWindowProperty::TOP_VIEW_INSET);
+ }
title_height = close_button_->GetPreferredSize().height();
}
gfx::Rect selector_item_bounds =
@@ -488,7 +496,7 @@ void WindowSelectorItem::SetItemBounds(const gfx::Rect& target_bounds,
// before the transform. Dividing by scale factor obtains the corner radius
// which when scaled will yield |kLabelBackgroundRadius|.
transform_window_.SetTransform(
- root_window_, transform,
+ root_window_, transform, use_mask_, use_shape_,
(kLabelBackgroundRadius / GetItemScale(target_bounds.size())));
transform_window_.set_overview_transform(transform);
}
@@ -580,8 +588,8 @@ void WindowSelectorItem::CreateWindowLabel(const base::string16& title) {
void WindowSelectorItem::UpdateHeaderLayout(
OverviewAnimationType animation_type) {
- gfx::Rect transformed_window_bounds =
- root_window_->ConvertRectFromScreen(GetTransformedBounds(GetWindow()));
+ gfx::Rect transformed_window_bounds = root_window_->ConvertRectFromScreen(
+ GetTransformedBounds(GetWindow(), hide_header()));
if (ash::MaterialDesignController::IsOverviewMaterial()) {
gfx::Rect label_rect(close_button_->GetPreferredSize());
« no previous file with comments | « ash/common/wm/overview/window_selector_item.h ('k') | ash/frame/custom_frame_view_ash.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698